Update notifications icons for media controls

VERIFIED FIXED in Firefox 50

Status

()

VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: antlam, Assigned: sebastian)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 50
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 verified)

Details

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
Created attachment 8761463 [details]
icon_notif.zip

In bug 1240423 we're using material icons. Since we have media controls in fennec that use our own icons, it would be visually more consistent to use our own here too. If it's not too hard, let's give these a try?

Attaching icons :)
(Reporter)

Updated

3 years ago
Flags: needinfo?(s.kaspari)
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Flags: needinfo?(s.kaspari)
Blocks: 1264901
Created attachment 8762079 [details]
Bug 1279137 - Update media notification icons.

Review commit: https://reviewboard.mozilla.org/r/58966/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58966/
Attachment #8762079 - Flags: review?(ahunt)
Created attachment 8762080 [details]
media_notification.png
Attachment #8762080 - Flags: feedback?(alam)
(Reporter)

Comment 3

3 years ago
Comment on attachment 8762080 [details]
media_notification.png

<3
Attachment #8762080 - Flags: feedback?(alam) → feedback+
Comment on attachment 8762079 [details]
Bug 1279137 - Update media notification icons.

https://reviewboard.mozilla.org/r/58966/#review56232

Assuming these are all optimised : )
Attachment #8762079 - Flags: review?(ahunt) → review+
(In reply to Andrzej Hunt :ahunt from comment #4)
> Assuming these are all optimised : )

Yep, I used ImageOptim on all of them. :)

Comment 6

3 years ago
Pushed by s.kaspari@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/75285ea7e4aa
Update media notification icons. r=ahunt

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/75285ea7e4aa
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Verified as fixed in build 50.0a1 (2016-06-15);
Device: LG G4 (Android 5.1).
Status: RESOLVED → VERIFIED
status-firefox50: fixed → verified
You need to log in before you can comment on or make changes to this bug.