127914 - [FIX]Shrink to fit only uses the first page for calculating ratio

Status: VERIFIED FIXED

(Core :: Print Preview, defect)

Description

[rods (gone)]

Shrink to Fit only checks the first page of each document instead of all the pages.

Comment 1

[rods (gone)]

Attachment: patch

1) This adds in a new layout atom for the SequenceFrame
2) Now checks all the SeqFrame's children (PageFrames) instead of just the
first one

Comment 2

[Kevin McCluskey (gone)]

nsbeta1+.

Comment 3

[rods (gone)]

Attachment: more commented patch

same changes as previous patch

Comment 4

[Marc Attinasi]

Comment on attachment 71609 [details] [diff] [review]
more commented patch

looks great! sr=attinasi

Comment 5

[Marc Attinasi]

Comment on attachment 71609 [details] [diff] [review]
more commented patch

looks great! sr=attinasi

Comment 6

[dcone (gone)]

r=dcone

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 71609 [details] [diff] [review]
more commented patch

a=asa (on behalf of drivers) for checkin to 0.9.9 branch and the trunk

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 71609 [details] [diff] [review]
more commented patch


>Index: layout/html/base/src/nsSimplePageSequence.h
>+  /**
>+   * Get the "type" of the frame
>+   *
>+   * @see nsLayoutAtoms::pageFrame
>+   */
>+  NS_IMETHOD GetFrameType(nsIAtom** aType) const;
>+  

Should that say

+   * @see nsLayoutAtoms::sequenceFrame

instead?

Comment 9

[rods (gone)]

I'll change that, thanks...

Comment 10

[rods (gone)]

fixed

Comment 11

[sujay]

Rod, please verify thanks!

Comment 12

[sujay]

verified.