1279145 - old error logs are not deleted

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P3)

Description

[:glob ✱]

i have a lot of old sync logs:

~/Library/Ap...edition-default$ cd weave/logs/
~/Library/Ap...ault/weave/logs$ ls -l
total 13336
-rw-r--r--  1 byron  staff    3929 18 Mar  2015 error-1426652543229.txt
-rw-r--r--  1 byron  staff    3798 20 Mar  2015 error-1426861138824.txt
-rw-r--r--  1 byron  staff   11554 20 Mar  2015 error-1426861139867.txt
-rw-r--r--  1 byron  staff    8301 20 Mar  2015 error-1426861140367.txt
-rw-r--r--  1 byron  staff    1956 20 Mar  2015 error-1426861140378.txt
-rw-r--r--  1 byron  staff    4071 23 Mar  2015 error-1427084889453.txt
-rw-------  1 byron  staff   70371 30 Mar  2015 error-readinglist-1427701272333.txt
-rw-------  1 byron  staff   14587 30 Mar  2015 error-readinglist-1427701272351.txt
-rw-------  1 byron  staff   14759 30 Mar  2015 error-readinglist-1427701283070.txt
-rw-------  1 byron  staff   14759 30 Mar  2015 error-readinglist-1427701288037.txt
-rw-------  1 byron  staff   14759 30 Mar  2015 error-readinglist-1427701323855.txt
-rw-------  1 byron  staff   14760 30 Mar  2015 error-readinglist-1427701325949.txt
-rw-------  1 byron  staff   14760 30 Mar  2015 error-readinglist-1427701648612.txt
-rw-------  1 byron  staff   14760 30 Mar  2015 error-readinglist-1427701649272.txt
-rw-------  1 byron  staff   14760 30 Mar  2015 error-readinglist-1427701790227.txt
-rw-------  1 byron  staff   14760 30 Mar  2015 error-readinglist-1427701791285.txt
-rw-------  1 byron  staff   14760 30 Mar  2015 error-readinglist-1427701796847.txt
-rw-------  1 byron  staff   14760 30 Mar  2015 error-readinglist-1427701797836.txt
-rw-------  1 byron  staff   32614 30 Mar  2015 error-readinglist-1427703472014.txt
-rw-------  1 byron  staff   13131 30 Mar  2015 error-readinglist-1427703472036.txt
-rw-------  1 byron  staff   19512 30 Mar  2015 error-readinglist-1427703651598.txt
-rw-------  1 byron  staff   13303 30 Mar  2015 error-readinglist-1427703683700.txt
-rw-------  1 byron  staff   25260 30 Mar  2015 error-readinglist-1427704907207.txt
-rw-------  1 byron  staff   13131 30 Mar  2015 error-readinglist-1427704907223.txt
-rw-------  1 byron  staff   13303 30 Mar  2015 error-readinglist-1427705024203.txt
-rw-------  1 byron  staff   13303 30 Mar  2015 error-readinglist-1427705025412.txt
-rw-------  1 byron  staff   19512 30 Mar  2015 error-readinglist-1427705985398.txt
-rw-------  1 byron  staff   13304 30 Mar  2015 error-readinglist-1427707913378.txt
-rw-------  1 byron  staff   19899 30 Mar  2015 error-readinglist-1427711754671.txt
-rw-------  1 byron  staff   26494 30 Mar  2015 error-readinglist-1427718955399.txt
-rw-------  1 byron  staff   22713 30 Mar  2015 error-readinglist-1427722448159.txt
-rw-------  1 byron  staff   12403 30 Mar  2015 error-readinglist-1427722448167.txt
-rw-------  1 byron  staff   12575 30 Mar  2015 error-readinglist-1427722448320.txt
-rw-------  1 byron  staff   12575 30 Mar  2015 error-readinglist-1427722448664.txt
-rw-------  1 byron  staff   12575 30 Mar  2015 error-readinglist-1427722448876.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722449010.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722449236.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722449342.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722449530.txt
-rw-------  1 byron  staff   12576 30 Mar  2015 error-readinglist-1427722449680.txt
-rw-------  1 byron  staff   12576 30 Mar  2015 error-readinglist-1427722449873.txt
-rw-------  1 byron  staff   12576 30 Mar  2015 error-readinglist-1427722450236.txt
-rw-------  1 byron  staff   12576 30 Mar  2015 error-readinglist-1427722450456.txt
-rw-------  1 byron  staff   12576 30 Mar  2015 error-readinglist-1427722450777.txt
-rw-------  1 byron  staff   12576 30 Mar  2015 error-readinglist-1427722450974.txt
-rw-------  1 byron  staff   12576 30 Mar  2015 error-readinglist-1427722451170.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722451319.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722451471.txt
-rw-------  1 byron  staff   12576 30 Mar  2015 error-readinglist-1427722451666.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722451772.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722451953.txt
-rw-------  1 byron  staff   12576 30 Mar  2015 error-readinglist-1427722452133.txt
-rw-------  1 byron  staff   12576 30 Mar  2015 error-readinglist-1427722452378.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722452514.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722452888.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722453044.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722453306.txt
-rw-------  1 byron  staff   12409 30 Mar  2015 error-readinglist-1427722453558.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722453960.txt
-rw-------  1 byron  staff   12409 30 Mar  2015 error-readinglist-1427722454035.txt
-rw-------  1 byron  staff   12409 30 Mar  2015 error-readinglist-1427722454203.txt
-rw-------  1 byron  staff   12409 30 Mar  2015 error-readinglist-1427722454293.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722454502.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722454643.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722454837.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722455004.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722455196.txt
-rw-------  1 byron  staff   12576 30 Mar  2015 error-readinglist-1427722455732.txt
-rw-------  1 byron  staff   12576 30 Mar  2015 error-readinglist-1427722456126.txt
-rw-------  1 byron  staff   12576 30 Mar  2015 error-readinglist-1427722457079.txt
-rw-------  1 byron  staff   12576 30 Mar  2015 error-readinglist-1427722457430.txt
-rw-------  1 byron  staff   12576 30 Mar  2015 error-readinglist-1427722457794.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722457956.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722458091.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722458266.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722458414.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722458607.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722458731.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722458940.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722459078.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722459245.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722459393.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722459573.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722459711.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722459937.txt
-rw-------  1 byron  staff   12409 30 Mar  2015 error-readinglist-1427722460197.txt
-rw-------  1 byron  staff   12409 30 Mar  2015 error-readinglist-1427722460547.txt
-rw-------  1 byron  staff   12409 30 Mar  2015 error-readinglist-1427722460652.txt
-rw-------  1 byron  staff   12409 30 Mar  2015 error-readinglist-1427722460842.txt
-rw-------  1 byron  staff   12409 30 Mar  2015 error-readinglist-1427722460951.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722461147.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722461318.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722461505.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722461647.txt
-rw-------  1 byron  staff   12409 30 Mar  2015 error-readinglist-1427722461844.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722462001.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722462190.txt
-rw-------  1 byron  staff   12409 30 Mar  2015 error-readinglist-1427722462343.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722462530.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722462693.txt
-rw-------  1 byron  staff   12409 30 Mar  2015 error-readinglist-1427722462880.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722464577.txt
-rw-------  1 byron  staff   12576 30 Mar  2015 error-readinglist-1427722467967.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722468122.txt
-rw-------  1 byron  staff   12409 30 Mar  2015 error-readinglist-1427722468263.txt
-rw-------  1 byron  staff   12409 30 Mar  2015 error-readinglist-1427722468384.txt
-rw-------  1 byron  staff   12409 30 Mar  2015 error-readinglist-1427722468573.txt
-rw-------  1 byron  staff   12482 30 Mar  2015 error-readinglist-1427722468701.txt
-rw-------  1 byron  staff   12503 30 Mar  2015 error-readinglist-1427722468911.txt
-rw-------  1 byron  staff   12409 30 Mar  2015 error-readinglist-1427722469003.txt
-rw-------  1 byron  staff   84171 30 Mar  2015 error-readinglist-1427729668770.txt
-rw-------  1 byron  staff   53200 31 Mar  2015 error-readinglist-1427736872337.txt
-rw-------  1 byron  staff   26494 31 Mar  2015 error-readinglist-1427744083556.txt
-rw-------  1 byron  staff   26565 31 Mar  2015 error-readinglist-1427751283521.txt
-rw-------  1 byron  staff   26494 31 Mar  2015 error-readinglist-1427758500822.txt
-rw-------  1 byron  staff   26494 31 Mar  2015 error-readinglist-1427765703031.txt
-rw-------  1 byron  staff   73444 31 Mar  2015 error-readinglist-1427772902805.txt
-rw-------  1 byron  staff   88299 31 Mar  2015 error-readinglist-1427780104370.txt
-rw-------  1 byron  staff  115186 31 Mar  2015 error-readinglist-1427787304147.txt
-rw-------  1 byron  staff   81883 31 Mar  2015 error-readinglist-1427794510622.txt
-rw-------  1 byron  staff   26494 31 Mar  2015 error-readinglist-1427801710569.txt
-rw-------  1 byron  staff   73396 31 Mar  2015 error-readinglist-1427808910354.txt
-rw-------  1 byron  staff  101513 31 Mar  2015 error-readinglist-1427816110132.txt
-rw-------  1 byron  staff   78519  1 Apr  2015 error-readinglist-1427823312139.txt
-rw-------  1 byron  staff   29446  1 Apr  2015 error-readinglist-1427830516010.txt
-rw-------  1 byron  staff   29517  1 Apr  2015 error-readinglist-1427837720087.txt
-rw-------  1 byron  staff   29446  1 Apr  2015 error-readinglist-1427844923364.txt
-rw-------  1 byron  staff   29446  1 Apr  2015 error-readinglist-1427852125259.txt
-rw-------  1 byron  staff   82605  1 Apr  2015 error-readinglist-1427859325032.txt
-rw-------  1 byron  staff  110208  1 Apr  2015 error-readinglist-1427866524808.txt
-rw-------  1 byron  staff  131460  1 Apr  2015 error-readinglist-1427873724586.txt
-rw-------  1 byron  staff   71368  1 Apr  2015 error-readinglist-1427880926939.txt
-rw-------  1 byron  staff   27789  1 Apr  2015 error-readinglist-1427888127760.txt
-rw-------  1 byron  staff   28916  1 Apr  2015 error-readinglist-1427895328022.txt
-rw-------  1 byron  staff  132623  1 Apr  2015 error-readinglist-1427902527795.txt
-rw-------  1 byron  staff   78186  2 Apr  2015 error-readinglist-1427909731772.txt
-rw-------  1 byron  staff   33874  2 Apr  2015 error-readinglist-1427916948398.txt
-rw-------  1 byron  staff   33874  2 Apr  2015 error-readinglist-1427924156127.txt
-rw-------  1 byron  staff   33945  2 Apr  2015 error-readinglist-1427931359308.txt
-rw-------  1 byron  staff   33874  2 Apr  2015 error-readinglist-1427938573344.txt
-rw-------  1 byron  staff   33874  2 Apr  2015 error-readinglist-1427945773474.txt
-rw-------  1 byron  staff  126017  2 Apr  2015 error-readinglist-1427952973248.txt
-rw-------  1 byron  staff  114981  2 Apr  2015 error-readinglist-1427960173021.txt
-rw-------  1 byron  staff   80220  2 Apr  2015 error-readinglist-1427967377164.txt
-rw-------  1 byron  staff   29517  2 Apr  2015 error-readinglist-1427974576970.txt
-rw-------  1 byron  staff   57274  2 Apr  2015 error-readinglist-1427981776760.txt
-rw-------  1 byron  staff  118400  2 Apr  2015 error-readinglist-1427988976537.txt
-rw-------  1 byron  staff  100573  3 Apr  2015 error-readinglist-1427996176367.txt
-rw-------  1 byron  staff   35350  3 Apr  2015 error-readinglist-1428003378035.txt
-rw-------  1 byron  staff   35350  3 Apr  2015 error-readinglist-1428010590856.txt
-rw-------  1 byron  staff   35421  3 Apr  2015 error-readinglist-1428017802870.txt
-rw-------  1 byron  staff   35350  3 Apr  2015 error-readinglist-1428025015262.txt
-rw-------  1 byron  staff   35350  3 Apr  2015 error-readinglist-1428032226782.txt
-rw-------  1 byron  staff   35398  3 Apr  2015 error-readinglist-1428039435330.txt
-rw-------  1 byron  staff   51801  3 Apr  2015 error-readinglist-1428046642768.txt
-rw-------  1 byron  staff   35350  3 Apr  2015 error-readinglist-1428053850073.txt
-rw-------  1 byron  staff   35421  3 Apr  2015 error-readinglist-1428061058782.txt
-rw-------  1 byron  staff   35350  3 Apr  2015 error-readinglist-1428068277884.txt
-rw-------  1 byron  staff   35350  3 Apr  2015 error-readinglist-1428075487101.txt
-rw-------  1 byron  staff   35398  4 Apr  2015 error-readinglist-1428082695670.txt
-rw-------  1 byron  staff   35350  4 Apr  2015 error-readinglist-1428089901264.txt
-rw-------  1 byron  staff   35350  4 Apr  2015 error-readinglist-1428097101274.txt
-rw-------  1 byron  staff   35421  4 Apr  2015 error-readinglist-1428104317371.txt
-rw-------  1 byron  staff   35350  4 Apr  2015 error-readinglist-1428111523921.txt
-rw-------  1 byron  staff   30295  4 Apr  2015 error-readinglist-1428118734222.txt
-rw-------  1 byron  staff   31614  4 Apr  2015 error-readinglist-1428125945465.txt
-rw-------  1 byron  staff   30295  4 Apr  2015 error-readinglist-1428133159414.txt
-rw-------  1 byron  staff   31566  4 Apr  2015 error-readinglist-1428140375710.txt
-rw-------  1 byron  staff   30366  4 Apr  2015 error-readinglist-1428147592045.txt
-rw-------  1 byron  staff   31566  4 Apr  2015 error-readinglist-1428154792099.txt
-rw-------  1 byron  staff   30295  4 Apr  2015 error-readinglist-1428162001857.txt
-rw-------  1 byron  staff   31614  5 Apr  2015 error-readinglist-1428169216940.txt
-rw-------  1 byron  staff   26511  5 Apr  2015 error-readinglist-1428176428840.txt
-rw-------  1 byron  staff   30295  5 Apr  2015 error-readinglist-1428183643248.txt
-rw-------  1 byron  staff   31637  5 Apr  2015 error-readinglist-1428190861575.txt
-rw-------  1 byron  staff   26511  5 Apr  2015 error-readinglist-1428198078076.txt
-rw-------  1 byron  staff   35350  5 Apr  2015 error-readinglist-1428205278386.txt
-rw-------  1 byron  staff   26511  5 Apr  2015 error-readinglist-1428212485551.txt
-rw-------  1 byron  staff   26559  5 Apr  2015 error-readinglist-1428219696776.txt
-rw-------  1 byron  staff   30295  5 Apr  2015 error-readinglist-1428226897847.txt
-rw-------  1 byron  staff   31566  5 Apr  2015 error-readinglist-1428234099545.txt
-rw-------  1 byron  staff   35421  5 Apr  2015 error-readinglist-1428241303032.txt
-rw-------  1 byron  staff   35350  5 Apr  2015 error-readinglist-1428248510130.txt
-rw-------  1 byron  staff   35350  6 Apr  2015 error-readinglist-1428255711830.txt
-rw-------  1 byron  staff   35398  6 Apr  2015 error-readinglist-1428262912105.txt
-rw-------  1 byron  staff   35350  6 Apr  2015 error-readinglist-1428270114138.txt
-rw-------  1 byron  staff   35350  6 Apr  2015 error-readinglist-1428277324683.txt
-rw-------  1 byron  staff   35421  6 Apr  2015 error-readinglist-1428284538999.txt
-rw-------  1 byron  staff   35350  6 Apr  2015 error-readinglist-1428291749706.txt
-rw-------  1 byron  staff   35350  6 Apr  2015 error-readinglist-1428298949612.txt
-rw-------  1 byron  staff   30343  6 Apr  2015 error-readinglist-1428306163400.txt
-rw-------  1 byron  staff   31566  6 Apr  2015 error-readinglist-1428313367909.txt
-rw-------  1 byron  staff   35350  6 Apr  2015 error-readinglist-1428320571182.txt
-rw-------  1 byron  staff   26511  6 Apr  2015 error-readinglist-1428327790654.txt
-rw-------  1 byron  staff   30366  6 Apr  2015 error-readinglist-1428334997013.txt
-rw-------  1 byron  staff   31566  7 Apr  2015 error-readinglist-1428342203407.txt
-rw-------  1 byron  staff   26511  7 Apr  2015 error-readinglist-1428349417774.txt
-rw-------  1 byron  staff   30343  7 Apr  2015 error-readinglist-1428356617608.txt
-rw-------  1 byron  staff   31566  7 Apr  2015 error-readinglist-1428363827241.txt
-rw-------  1 byron  staff   35350  7 Apr  2015 error-readinglist-1428371035455.txt
-rw-------  1 byron  staff  116942  7 Apr  2015 error-readinglist-1428378235258.txt
-rw-------  1 byron  staff  140595  7 Apr  2015 error-readinglist-1428385435038.txt
-rw-------  1 byron  staff   27868 31 May 21:50 error-sync-1464702631672.txt
-rw-------  1 byron  staff   25137 31 May 21:50 error-sync-1464702633522.txt
-rw-------  1 byron  staff   27819 31 May 21:51 error-sync-1464702694472.txt
-rw-------  1 byron  staff   27228 31 May 21:51 error-sync-1464702696537.txt
-rw-------  1 byron  staff   31437 31 May 22:01 error-sync-1464703299563.txt
-rw-------  1 byron  staff   30708 31 May 22:11 error-sync-1464703901695.txt
-rw-------  1 byron  staff   31045 31 May 22:21 error-sync-1464704503667.txt
-rw-------  1 byron  staff   31633 31 May 22:31 error-sync-1464705106049.txt
-rw-------  1 byron  staff   30370 31 May 22:41 error-sync-1464705708122.txt
-rw-------  1 byron  staff   32984 31 May 22:51 error-sync-1464706311284.txt
-rw-------  1 byron  staff   31349 31 May 23:01 error-sync-1464706913816.txt

looks like old error-sync-* logs are being deleted, but not error- and error-reading-list-

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1279145 - log manager now cleans old Sync and ReadingList log files.

Review commit: https://reviewboard.mozilla.org/r/64812/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64812/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

https://reviewboard.mozilla.org/r/64812/#review61814

::: services/common/logmanager.js:135
(Diff revision 1)
>    }),
>  }
>  
>  // The public LogManager object.
>  function LogManager(prefRoot, logNames, logFilePrefix) {
> +  this._prefObservers = [];

Note that this change isn't strictly for this bug, but is an issue I noticed running the tests. Later in init() we this._prefObservers.push(...) which mutates the list on the prototype - when .finalize() ran it lefts the entries in the prototype, so each new instance of LogManager left stuff in that prototype. This change just ensures this._prefObservers is on the object rather than the proto and avoids warnings in that test.

Comment 3

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 8771813 [details]
Bug 1279145 - log manager now cleans old Sync and ReadingList log files.

https://reviewboard.mozilla.org/r/64812/#review61920

Looks good to me.

::: services/common/logmanager.js:135
(Diff revision 1)
>    }),
>  }
>  
>  // The public LogManager object.
>  function LogManager(prefRoot, logNames, logFilePrefix) {
> +  this._prefObservers = [];

I was going to ask about this, that makes sense (I didn't realize you could put comments here ahead of time -- I'll probably start doing that). It does look like that doesn't belong on the proto.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/664b7f0f5124
log manager now cleans old Sync and ReadingList log files. r=tcsc

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/664b7f0f5124