1279153 - Add support for Reduced Size RTCP (rtcp-rsize) per RFC 5506

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P3)

Description

[Nils Ohlmeier [:drno]]

This involves at least:
- make our checks for incoming RTCP in MediaPipelineFilter::FilterSenderReport less strict.
  https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/mediapipeline/MediaPipelineFilter.cpp#75
- add a=rtcp-rsize to our SDP (which Chrome 51 already does)
- probably need to check which version of webrtc.org actually supports sending reduced size RTCP

Comment 1

[Nils Ohlmeier [:drno]]

@Randell do you know which version of webrtc.org supports reduced size RTCP? As Chrome 51 advertises support via a=rtcp-rsize I assume at least the latest version supports it.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Landed upstream on 3/18: https://codereview.webrtc.org/1713493003
https://bugs.chromium.org/p/webrtc/issues/detail?id=4868
I'd guess either 50 or 51; probably 51

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Also: we should check if the FilterSenderReport/channel might ever get packets other than an SR, given which direction channel it is - but likely we shouldn't drop them in any case, and let the webrtc.org code handle them if the SSRC is right.

Comment 4

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.

Comment 5

[Nils Ohlmeier [:drno]]

Looks like our current version of libwebrtc has native support for rsize https://searchfox.org/mozilla-central/rev/158bac3df3a1890da55bdb6ffdaf9a7ffc0bfb0a/media/webrtc/trunk/webrtc/common_types.h#957

Comment 6

[Nils Ohlmeier [:drno]]

And we simply configure compound RTCP as default here https://searchfox.org/mozilla-central/rev/158bac3df3a1890da55bdb6ffdaf9a7ffc0bfb0a/media/webrtc/signaling/src/media-conduit/VideoConduit.cpp#1541

Comment 7

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d381bfe75a517a0f1a363065496ff71f8f0226b7

Comment 8

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1279153 - Add support for rtcp-rsize;r?bwc r=dminor!

Comment 9

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9e78ebb02ccafefac1118398d9199e7bceaa03c

Comment 10

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ddf3a91e3b57bda9a3613e9f7878fd04a2f7b7b9

Comment 11

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1e55193349bfe7a139568176842ecfd17fbf7e8

Comment 12

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bac1ea0a944d398305a2b1113e8e0bb16eb5f102

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d5af987d772
Add support for rtcp-rsize;r=bwc,dminor

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4d5af987d772