Closed Bug 1279194 Opened 5 years ago Closed 5 years ago

Get rid of nsDOMPerformanceNavigationType

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

(Whiteboard: btpp-active)

Attachments

(1 file, 1 obsolete file)

performance7b.patch
8.12 KB, patch
smaug
: review+
Details | Diff | Splinter Review
Attached patch performance7.patch (obsolete) — — Splinter Review 
No description provided.
Attachment #8761532 - Flags: review?(bugs)
Attachment #8761532 - Flags: review?(bugs)
Whiteboard: btpp-active
Attachment #8761532 - Attachment is obsolete: true
Attachment #8761830 - Flags: review?(bugs)
Comment on attachment 8761830 [details] [diff] [review]
performance7b.patch

> class nsDOMNavigationTiming final
> {
> public:
>+  enum NavigationTimingType {
Could this be called just Type ?
It is after all inside nsDOMNavigationTiming, so should be clear what it means.
Attachment #8761830 - Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6adfec553de8
Get rid of nsDOMPerformanceNavigationType, r=smaug
https://hg.mozilla.org/mozilla-central/rev/6adfec553de8
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.