Closed
Bug 1279199
Opened 9 years ago
Closed 9 years ago
links to changesets in sign-off/signoff view contain double slash (//)
Categories
(Webtools Graveyard :: Elmo, defect)
Webtools Graveyard
Elmo
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: aryx, Assigned: aryx)
Details
Attachments
(1 file)
E.g. https://l10n.mozilla.org/shipping/signoffs/de/fx48#0fb75106f062 links to http://hg.mozilla.org/releases/l10n/mozilla-beta/de//rev/0fb75106f062
The links still work.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8761538 -
Flags: review?(l10n)
|
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8761538 [details] [review]
pull request, v1
We make the assumption that repos and forests end with a '/' at a few places, seems that this is the only that doesn't.
Sadly, nothing enforces that '/', I'll split that out to a new bug. I think the right way to do that is to create a https://docs.djangoproject.com/en/1.8/ref/signals/#django.db.models.signals.pre_save handler that does so.
Attachment #8761538 -
Flags: review?(l10n) → review+
|
||
Comment 3•9 years ago
|
||
Commit pushed to develop at https://github.com/mozilla/elmo
https://github.com/mozilla/elmo/commit/1f4896b12a0133b966faa5749b2f64d84a277fc3
Bug 1279199 - links to changesets in sign-off view shouldn't use double slashes. r?Pike
|
|
||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•