Closed
Bug 1279210
Opened 5 years ago
Closed 5 years ago
mach eslint --setup can no longer install eslint-plugin-mozilla after move to tools/lint
Categories
(Firefox Build System :: Lint and Formatting, defect)
Tracking
(firefox50 fixed)
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
Details
Attachments
(1 file)
Follow up to 1271734. ./mach eslint --setup because it tries to locate eslint-plugin-mozilla in testing/esling. A path needs updating in tools/lint/mach_commands.py
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/58664/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/58664/
Attachment #8761557 -
Flags: review?(ahalberstadt)
Comment 2•5 years ago
|
||
Comment on attachment 8761557 [details] Bug 1279210 - eslint setup: fix eslint module path; https://reviewboard.mozilla.org/r/58664/#review55660 Ah, sorry about that! I did a dxr for 'testing/eslint' but evidently neglected join.
Attachment #8761557 -
Flags: review?(ahalberstadt) → review+
Comment 3•5 years ago
|
||
Thanks for finding/fixing. I took the liberty of autolanding this.
Comment 4•5 years ago
|
||
(In reply to Andrew Halberstadt [:ahal] from comment #3) > Thanks for finding/fixing. I took the liberty of autolanding this. Did this not work? I don't see any commits here?
Flags: needinfo?(jdescottes)
Flags: needinfo?(ahalberstadt)
Comment 5•5 years ago
|
||
Somehow not recorded here by pulsebot, but: https://hg.mozilla.org/integration/mozilla-inbound/rev/7fc8f70a567d4492607906d40532ef4a7124c8f5
Flags: needinfo?(jdescottes)
Flags: needinfo?(ahalberstadt)
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7fc8f70a567d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Updated•3 years ago
|
Product: Testing → Firefox Build System
Updated•2 years ago
|
Version: Version 3 → 3 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•