Closed Bug 1279210 Opened 5 years ago Closed 5 years ago
mach eslint --setup can no longer install eslint-plugin-mozilla after move to tools/lint
58 bytes, text/x-review-board-request
Follow up to 1271734. ./mach eslint --setup because it tries to locate eslint-plugin-mozilla in testing/esling. A path needs updating in tools/lint/mach_commands.py
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Review commit: https://reviewboard.mozilla.org/r/58664/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/58664/
Attachment #8761557 - Flags: review?(ahalberstadt)
Comment on attachment 8761557 [details] Bug 1279210 - eslint setup: fix eslint module path; https://reviewboard.mozilla.org/r/58664/#review55660 Ah, sorry about that! I did a dxr for 'testing/eslint' but evidently neglected join.
Attachment #8761557 - Flags: review?(ahalberstadt) → review+
Thanks for finding/fixing. I took the liberty of autolanding this.
(In reply to Andrew Halberstadt [:ahal] from comment #3) > Thanks for finding/fixing. I took the liberty of autolanding this. Did this not work? I don't see any commits here?
Somehow not recorded here by pulsebot, but: https://hg.mozilla.org/integration/mozilla-inbound/rev/7fc8f70a567d4492607906d40532ef4a7124c8f5
You need to log in before you can comment on or make changes to this bug.