Closed Bug 1279330 Opened 8 years ago Closed 8 years ago

Make checkstyle happy again about PostUpdateHandler.java

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Tracking Status
firefox50 --- fixed

People

(Reporter: JanH, Assigned: justindarc)

References

Details

Attachments

(1 file)

      No description provided.
Attached patch bug1279330.patchSplinter Review
Fix whitespace.
Attachment #8761804 - Flags: review?(jh+bugzilla)
Assignee: jh+bugzilla → jdarcangelo
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Attachment #8761804 - Flags: review?(jh+bugzilla) → review+
Keywords: checkin-needed
Hi,

this seems to have problems to apply:

could you take a look, thanks

renamed 1279330 -> bug1279330.patch
applying bug1279330.patch
patching file mobile/android/base/java/org/mozilla/gecko/updater/PostUpdateHandler.java
Hunk #1 FAILED at 65
1 out of 1 hunks FAILED -- saving rejects to file mobile/android/base/java/org/mozilla/gecko/updater/PostUpdateHandler.java.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh bug1279330.patch
Flags: needinfo?(jdarcangelo)
Keywords: checkin-needed
Pushed by kvijayan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca4f94f75f89
Make checkstyle happy again about PostUpdateHandler.java r=JanH
https://hg.mozilla.org/mozilla-central/rev/ca4f94f75f89
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Flags: needinfo?(jdarcangelo)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: