1279366 - handle @@hasInstance correctly for proxies

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Morgan Phillips [:mrrrgn]]

// InstanceofOperator -> GetMethod -> GetV -> [[Get]]
// InstanceofOperator -> OrdinaryHasInstance -> Get -> [[Get]]
var get = [];
var p = new Proxy(Function(), { get: function(o, k) { get.push(k); return o[k]; }});
({}) instanceof p;
return get[0] === Symbol.hasInstance && get.slice(1) + '' === "prototype";

Comment 1

[Tom S [:evilpie]]

Attachment: Handle hasInstance in scripted proxies

This just forwards the hasInstance trap to the InstanceOfOperator, this basically makes the indirection through the hasInstance trap invisible.

Comment 2

[Morgan Phillips [:mrrrgn]]

Comment on attachment 8761969 [details] [diff] [review]
Handle hasInstance in scripted proxies

Oh, it looks like the patch is truncated. Could you attach it again?

Comment 3

[Tom S [:evilpie]]

Attachment: v2 - Handle hasInstance in scripted proxies

Fail ..

Comment 4

[Morgan Phillips [:mrrrgn]]

Comment on attachment 8762128 [details] [diff] [review]
v2 - Handle hasInstance in scripted proxies

Review of attachment 8762128 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/130240034c37
Handle @@hasInstance correctly for proxies. r=mrrrgn

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/130240034c37