Closed Bug 1279397 Opened 8 years ago Closed 8 years ago

Remove gfxQPainterSurface

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

patch
6.96 KB, patch
eflores
: review+
Details | Diff | Splinter Review 
gfxQPainterSurface is only created by gfxASurface::Wrap to wrap a cairo_surface_t of type CAIRO_SURFACE_TYPE_QT, but the only code that creates surfaces of that type (by calling cairo_qt_surface_create) is the gfxQPainterSurface constructors. So we can never create gfxQPainterSurface objects, and gfxQPainterSurface is dead code.
Attached patch patch — — Splinter Review 

        Attachment #8761891 -
        Flags: review?(edwin)

    
    

    
  
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9de33d87195b
Remove gfxQPainterSurface. r=eflores

    
    

    
  
I should have mentioned my rational for being able to remove the code in gfxASurface::Wrap - nobody outside of gfxQPainterSurface itself calls cairo_qt_surface_create, so we should never run that code.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/9de33d87195b
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox50:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: