Closed Bug 1279397 Opened 3 years ago Closed 3 years ago

Remove gfxQPainterSurface

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

gfxQPainterSurface is only created by gfxASurface::Wrap to wrap a cairo_surface_t of type CAIRO_SURFACE_TYPE_QT, but the only code that creates surfaces of that type (by calling cairo_qt_surface_create) is the gfxQPainterSurface constructors. So we can never create gfxQPainterSurface objects, and gfxQPainterSurface is dead code.
Attached patch patchSplinter Review
Attachment #8761891 - Flags: review?(edwin)
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9de33d87195b
Remove gfxQPainterSurface. r=eflores
I should have mentioned my rational for being able to remove the code in gfxASurface::Wrap - nobody outside of gfxQPainterSurface itself calls cairo_qt_surface_create, so we should never run that code.
https://hg.mozilla.org/mozilla-central/rev/9de33d87195b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
jwatt++
You need to log in before you can comment on or make changes to this bug.