Remove wsock32 and mswsock from OS_LIBS

NEW
Unassigned

Status

2 years ago
6 months ago

People

(Reporter: m_kato, Unassigned)

Tracking

Trunk
Unspecified
Windows

Firefox Tracking Flags

(firefox50 affected)

Details

(Reporter)

Description

2 years ago
wsock32.dll is compatibility layer for old Windows that is WinSock 1.x.   Windows 2000 or later supports WinSock 2.x (ws2_32.dll).

So wsock32.dll is unnecessary.  And mswsock is unused.   (It will be loaded by ws2_32.dll)
(Reporter)

Updated

2 years ago
OS: Unspecified → Windows
(Reporter)

Comment 1

2 years ago
Humm, UDP such as dom/network/tests/test_udpsocket.html doesn't seem to work correctly...  I am investigating.
Did you replace all <winsock.h> includes with <winsock2.h>? Both headers have incompatible IPPROTO_IP definitions.
http://www.geekpage.jp/programming/winsock/tips-setsockopt.php (Japanese)
(Reporter)

Comment 3

2 years ago
(In reply to Masatoshi Kimura [:emk] from comment #2)
> Did you replace all <winsock.h> includes with <winsock2.h>? Both headers
> have incompatible IPPROTO_IP definitions.
> http://www.geekpage.jp/programming/winsock/tips-setsockopt.php (Japanese)

Oh, Thanks, emk-san.  We should update nspr too.
Maybe we should guarantee Firefox and NSPR use the consistent winsock version somehow.

Updated

6 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.