1279453 - Remove separate worker binding for ServiceWorkerRegistration API

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: swr.patch

This code moves code around, mainly. Instead having 1 ServiceWorkerRegistrationBase class and then 2 webIDL classes (ServiceWorkerRegistrationMainThread and ServiceWorkerRegistrationWorkerThread), with this patch we have:

. ServiceWorkerRegistration that is the webIDL class.
. ServiceWorkerRegistrationMainThread, not directly exposed.
. ServiceWorkerRegistrationWorkerThread, not directly exposed.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8761974 [details] [diff] [review]
swr.patch

Review of attachment 8761974 [details] [diff] [review]:
-----------------------------------------------------------------

Nice cleanup.  Thanks!

::: dom/workers/ServiceWorkerRegistration.cpp
@@ +75,5 @@
> +
> +class ServiceWorkerRegistrationMainThread final : public ServiceWorkerRegistration,
> +                                                  public ServiceWorkerRegistrationListener
> +{
> +  friend nsPIDOMWindowInner;

Why do we need this friend declaration?

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/559f31d84a6e
Remove separate worker binding for ServiceWorkerRegistration API, r=bkelly

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/559f31d84a6e