Closed Bug 1279465 Opened 3 years ago Closed 3 years ago

Don't grey out the green lock icon in the identity box on hover

Categories

(Firefox :: General, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 50
Iteration:
50.1 - Jun 20
Tracking Status
firefox48 --- verified
firefox49 --- verified
firefox50 --- verified

People

(Reporter: johannh, Assigned: johannh)

References

Details

(Whiteboard: [fxprivacy])

Attachments

(1 file)

In Bug 1278926 and Bug 1278926 we decided to revert the decision to grey out the green lock (and other future icons) in the identity box).
See Also: → 1223049
This was implemented in Bug 1223049, needs to be backed out.
Comment on attachment 8762002 [details] [diff] [review]
Back out changeset 4ca15e44f0b5 to prevent inconsistency with future designs

Carrying over r+ from Paolo from https://bugzilla.mozilla.org/show_bug.cgi?id=1206246#c14
Attachment #8762002 - Flags: review+
Flags: qe-verify+
Comment on attachment 8762002 [details] [diff] [review]
Back out changeset 4ca15e44f0b5 to prevent inconsistency with future designs

Approval Request Comment
[Feature/regressing bug #]: Bug 1223049
[User impact if declined]: Users will perceive a visual change in the identity box that will be removed again with the next release. We'd like to avoid that inconsistency.
[Describe test coverage new/current, TreeHerder]: I've requested QA since this is a visual change only.
[Risks and why]: Virtually no imaginable risk. This is a small, very specific CSS change that is highly unlikely to affect other code.
[String/UUID change made/needed]: none
Attachment #8762002 - Flags: approval-mozilla-beta?
Attachment #8762002 - Flags: approval-mozilla-aurora?
Keywords: checkin-needed
Whiteboard: [fxprivacy] → [fxprivacy][triage]
Iteration: --- → 50.1
Priority: -- → P1
QA Contact: paul.silaghi
Whiteboard: [fxprivacy][triage] → [fxprivacy]
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/0fcee5543705
Back out changeset 4ca15e44f0b5 to prevent inconsistency with future designs. r=paolo
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0fcee5543705
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
I managed to test this bug on 50.0a1 (2016-06-13)
using 
- Windows 10 x64
- Mac OS X 10.11
- Ubuntu 14.04 x86
The fix has landed and it works as expected, so I am marking this issue as Verified Fixed.
Status: RESOLVED → VERIFIED
Comment on attachment 8762002 [details] [diff] [review]
Back out changeset 4ca15e44f0b5 to prevent inconsistency with future designs

Improve the situation, taking it.
Should be in 48 beta 2
Attachment #8762002 - Flags: approval-mozilla-beta?
Attachment #8762002 - Flags: approval-mozilla-beta+
Attachment #8762002 - Flags: approval-mozilla-aurora?
Attachment #8762002 - Flags: approval-mozilla-aurora+
I continued the verification process for latest Aurora 49.0a2 (2016-06-21) on 
- Windows 10 x64
- Mac OS X 10.11
- Ubuntu 14.04 x86
The fix works well on this build, too.
It seems that on 48.0b2 build1 (20160620091522) the fix didn't land yet. I will verify this bug in the next beta build.
I verified this bug on 48.0b4 build1 (20160627144420), too, using 
- Windows 10 x64
- Ubuntu 14.04 x86
- Mac OS X 10.11
The fix looks good and I found no misbehavior. I set the corresponding flag.
You need to log in before you can comment on or make changes to this bug.