1279515 - Bump ESLint rule version after change

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

It looks like we now need to bump the Mozilla ESLint plugin's version when making a change since it's no longer globally symlinked.

This was skipped recently as part of bug 1193390, so let's bump it now.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1279515 - Update ESLint plugin version after rule change.

Review commit: https://reviewboard.mozilla.org/r/58958/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58958/

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8dbdc9a21fa3

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8762072 [details]
Bug 1279515 - Update ESLint plugin version after rule change.

https://reviewboard.mozilla.org/r/58958/#review55954

Thank you for taking care of this.
Looks good to me.

::: tools/lint/eslint/update:41
(Diff revision 1)
>  echo "Removing node_modules and npm_shrinkwrap.json..."
>  rm -rf node_modules/
>  rm npm-shrinkwrap.json
>  
>  echo "Installing eslint and dependencies..."
> -../../mach eslint --setup
> +../../../mach eslint --setup

good catch!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/cd4cfadeedf2
Update ESLint plugin version after rule change. r=jdescottes

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cd4cfadeedf2