Closed Bug 1279515 Opened 4 years ago Closed 4 years ago

Bump ESLint rule version after change

Categories

(Firefox Build System :: Lint and Formatting, defect)

defect
Not set

Tracking

(firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

Details

Attachments

(1 file)

It looks like we now need to bump the Mozilla ESLint plugin's version when making a change since it's no longer globally symlinked.

This was skipped recently as part of bug 1193390, so let's bump it now.
Comment on attachment 8762072 [details]
Bug 1279515 - Update ESLint plugin version after rule change.

https://reviewboard.mozilla.org/r/58958/#review55954

Thank you for taking care of this.
Looks good to me.

::: tools/lint/eslint/update:41
(Diff revision 1)
>  echo "Removing node_modules and npm_shrinkwrap.json..."
>  rm -rf node_modules/
>  rm npm-shrinkwrap.json
>  
>  echo "Installing eslint and dependencies..."
> -../../mach eslint --setup
> +../../../mach eslint --setup

good catch!
Attachment #8762072 - Flags: review?(jdescottes) → review+
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/cd4cfadeedf2
Update ESLint plugin version after rule change. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/cd4cfadeedf2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Product: Testing → Firefox Build System
You need to log in before you can comment on or make changes to this bug.