Closed Bug 1279534 Opened 4 years ago Closed 3 years ago

Update fetchlogs.py script for treeherder changes

Categories

(Testing :: web-platform-tests, defect)

defect
Not set

Tracking

(firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jgraham, Unassigned)

Details

Attachments

(1 file)

No description provided.
https://reviewboard.mozilla.org/r/58970/#review55972

One nit.

::: testing/web-platform/update/fetchlogs.py:68
(Diff revision 1)
>  
>  def get_blobber_url(branch, job):
> -    job_id = job["id"]
> -    artifact_url = urlparse.urljoin(treeherder_base, "/api/project/%s/artifact/" % branch)
> +    job_guid = job["job_guid"]
> +    artifact_url = urlparse.urljoin(treeherder_base, "/api/jobdetail/")
>      artifact_params = {
> -        'job_id': job_id,
> +        'job__guid': job_guid,

You should use job_guid instead of job__guid here (which works as of bug 1278597)
Comment on attachment 8762082 [details]
Bug 1279534 - Update wpt log fetching script for treeherder changes,

https://reviewboard.mozilla.org/r/58970/#review56272

See open issue (sorry for leaving this open for so long, reviewboard confuses me)
Attachment #8762082 - Flags: review?(wlachance) → review-
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/39e17b36a828
Update wpt log fetching script for treeherder changes, r=wlach
https://hg.mozilla.org/mozilla-central/rev/39e17b36a828
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.