Tech checklist: - Rename remotePeerDisconnected/remotePeerConnected actions - Change the calling locations to be from the participantStore#_updateParticipantData - If easy: include participant name in the action as well, and change the string to say "<friend> has joined the room" etc.
40 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
Currently on Akita, the "Your friend has joined/left" are displayed when the peer starts WebRTC, they should be when they open or close the room.
Created attachment 8762237 [details] [review] [loop] daveccrit:1279553-joinLeaveChatMessages > mozilla:akita
Comment on attachment 8762237 [details] [review] [loop] daveccrit:1279553-joinLeaveChatMessages > mozilla:akita Looking good but we should add tests for the new bits of code.
Got tests working again. Pushed update to github, marked as work in progress. There were some dispatch event issues with updatePresence, not sure if as a result of fixes or if underlying issue.
Support for Hello/Loop has been discontinued. https://support.mozilla.org/kb/hello-status Hence closing the old bugs. Thank you for your support.