Akita: "Your friend has Joined/left" should be displayed when they open the room, rather than when a WebRTC session starts

RESOLVED INCOMPLETE

Status

Hello (Loop)
Client
P1
normal
Rank:
9
RESOLVED INCOMPLETE
a year ago
a year ago

People

(Reporter: standard8, Assigned: dcritch)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

User Story

Tech checklist:

- Rename remotePeerDisconnected/remotePeerConnected actions
- Change the calling locations to be from the participantStore#_updateParticipantData
- If easy: include participant name in the action as well, and change the string to say "<friend> has joined the room" etc.

Attachments

(1 attachment)

(Reporter)

Description

a year ago
Currently on Akita, the "Your friend has joined/left" are displayed when the peer starts WebRTC, they should be when they open or close the room.
(Reporter)

Updated

a year ago
Rank: 10

Comment 1

a year ago
Created attachment 8762237 [details] [review]
[loop] daveccrit:1279553-joinLeaveChatMessages > mozilla:akita
(Reporter)

Updated

a year ago
Duplicate of this bug: 1274142
(Assignee)

Updated

a year ago
Attachment #8762237 - Flags: review?(standard8)

Updated

a year ago
Blocks: 1280568
(Reporter)

Comment 3

a year ago
Comment on attachment 8762237 [details] [review]
[loop] daveccrit:1279553-joinLeaveChatMessages > mozilla:akita

Looking good but we should add tests for the new bits of code.
Attachment #8762237 - Flags: review?(standard8)

Updated

a year ago
Rank: 10 → 9
(Assignee)

Comment 4

a year ago
Got tests working again. Pushed update to github, marked as work in progress. There were some dispatch event issues with updatePresence, not sure if as a result of fixes or if underlying issue.
(Reporter)

Comment 5

a year ago
Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.