Closed Bug 127958 Opened 23 years ago Closed 23 years ago

Folder Properties: both newsgroup and folder in offline panel, 2 download buttons

Categories

(SeaMonkey :: MailNews: Message Display, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED DUPLICATE of bug 127938
mozilla1.0

People

(Reporter: laurel, Assigned: sspitzer)

Details

(Keywords: regression)

Attachments

(1 file)

Using feb26 commercial trunk Regression, not in feb25 build The folder properties dialog shows both newsgroup and folder offline options and has two Download Now buttons. Should only show one option, appropriate to whether folder or group selected.
QA Contact: esther → gchan
Keywords: nsbeta1, regression
reassigning to ssu.
Keywords: nsbeta1nsbeta1+
Priority: -- → P2
Target Milestone: --- → mozilla1.0
I have a bad feeling about this - none of the relevant mailnews ui files changed between the 25th and 26th, so this would seem to be a regression caused by a change to some toolkit or layout changes. Or, maybe, god forbid, xpconnect...
I updated almost all of the directories changed that could have caused this regression, one by one, and couldn't recreate the problem. These include mailnews, layout, xpfe, js, xpcom, widget, themes, and gfx. I didn't update dom, docshell, intl, or caps, though I don't know how they could be involved. Obviously, the hidefor isn't happening correctly. Lots of other things are broken in this dialog. Here's the console output: folder props loaded JavaScript error: chrome://global/content/dialogOverlay.js line 70: opener has no properties
OK, looks like mstoltz's dom changes to nsGlobalWindow.cpp,h - null opener means dialogOverlay.js throws an exception when moveToAlertPosition is called, and our mailnews dialog onload handler doesn't get to finish because we call moveToAlertPosition.
it looks like this would break our new folder dialog, our rename folder dialog, the filter editor, and the custom headers dialog.
mstoltz, since I'm not allowed to see what bug you were trying to fix, perhaps you could advise us how to proceed - are we never going to get an opener? Should we not ever call moveToAlertPosition (which would really suck, wouldn't it?)
probably adding redundant info but neither the checkboxes or download now buttons work as expected. The download now button doesn't download the newsgroup/mail folder and clicking the checkbox doesn't result in the folder/newsgrp being selected in the 'items for offline usage' window.
New folder bug is bug 127938. I think when Mitch fixes that bug, this bug will be fixed as a result.
dup. *** This bug has been marked as a duplicate of 127938 ***
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
Tested commercial trunk 2002030103 on NT 4.0 2002030108 on mac 10.1.3 & linux 2.2 Only one download now button. Checking the checkbox results in the folder being selected in the 'items for offline usage' window. Verifying dupe.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: