1279596 - Add more features to mercurial config wizard

Status: RESOLVED FIXED

(Developer Services :: Mercurial: configwizard, defect)

Description

[Gregory Szorc [:gps]]

Bug 1277406 was a straight port of the config wizard. I'd like to add some follow-up features:

* pager
* color definitions
* mozilla.ircnick
* Bugzilla API Key verification
* evolve
* blackbox
* "review" path

Not sure I'll get all of them in this bug. But I can try.

Comment 1

[Gregory Szorc [:gps]]

Attachment: configwizard: prompt to enable blackbox extension (bug 1279596);

The blackbox extension provides forensic logging of commands, their
times, and other info useful for debugging performance problems
and how people got to where they are. Countless times I've had to
ask for its output in bug reports only to find out people don't
have it enabled.

So let's offer to enable it.

Review commit: https://reviewboard.mozilla.org/r/59026/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59026/

Comment 2

[Gregory Szorc [:gps]]

Attachment: configwizard: prompt to enable and configure pager (bug 1279596);

Lack of pager is IMO one of the most annoying things in a default
Mercurial config.

Enabling the pager extension gets a partially useful pager. But
I feel you have to configure it a bit more, namely enabling it
on other commands and defining a custom `less` invocation to
make it behave better. `less` without -F in particular is quite
annoying because you have to exit the pager for every command,
even if it prints a single line of output!

The config added in this commit mostly matches my local config.
I think it is a good starting point.

Review commit: https://reviewboard.mozilla.org/r/59028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59028/

Comment 3

[Gregory Szorc [:gps]]

Attachment: configwizard: prompt to configure the "review" path (bug 1279596);

We recently removed the automagical "review" path from firefoxtree
(bug 1275122). Let's make it explicit by having the config wizard
prompt for it.

This code isn't perfect: we won't prompt to add the "review" path
if we've already run the wizard once. The whole code review
setup workflow needs some love.

Review commit: https://reviewboard.mozilla.org/r/59030/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59030/

Comment 4

[Gregory Szorc [:gps]]

Attachment: configwizard: prompt to enable curses interfaces (bug 1279596);

Review commit: https://reviewboard.mozilla.org/r/59032/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59032/

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8762174 [details]
configwizard: prompt to configure the "review" path (bug 1279596);

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59030/diff/1-2/

Comment 6

[:glob ✱]

Comment on attachment 8762172 [details]
configwizard: prompt to enable blackbox extension (bug 1279596);

https://reviewboard.mozilla.org/r/59026/#review56260

Comment 7

[:glob ✱]

Comment on attachment 8762173 [details]
configwizard: prompt to enable and configure pager (bug 1279596);

https://reviewboard.mozilla.org/r/59028/#review56262

Comment 8

[:glob ✱]

Comment on attachment 8762174 [details]
configwizard: prompt to configure the "review" path (bug 1279596);

https://reviewboard.mozilla.org/r/59030/#review56264

Comment 9

[:glob ✱]

Comment on attachment 8762181 [details]
configwizard: prompt to enable curses interfaces (bug 1279596);

https://reviewboard.mozilla.org/r/59032/#review56266

fix issue on commit please.

::: hgext/configwizard/__init__.py:542
(Diff revision 1)
> +            try:
> +                import wcurses
> +            except Exception:
> +                return
> +
> +    if ui.promptchoice(CURSES_INFO):

this should be uipromptchoice() not ui.promptchoice().

Comment 10

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/cf206cf4a05b3a8065bf5fc8ce6d05e115b9f6c6
configwizard: prompt to enable blackbox extension (bug 1279596); r=glob

https://hg.mozilla.org/hgcustom/version-control-tools/rev/bea351f10deba783ded941922b0f8837fe769f3e
configwizard: prompt to enable and configure pager (bug 1279596); r=glob

https://hg.mozilla.org/hgcustom/version-control-tools/rev/56c761783379a12748d6487bb95fd24f58005b28
configwizard: prompt to configure the "review" path (bug 1279596); r=glob

https://hg.mozilla.org/hgcustom/version-control-tools/rev/e240bcd764627eda92ec0b2d9117a017adb17624
configwizard: prompt to enable curses interfaces (bug 1279596); r=glob

Comment 11

[Gregory Szorc [:gps]]

Will file more bugs for additional features.