Closed Bug 1279596 Opened 3 years ago Closed 3 years ago

Add more features to mercurial config wizard

Categories

(Developer Services :: Mercurial: configwizard, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gps, Assigned: gps)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

Bug 1277406 was a straight port of the config wizard. I'd like to add some follow-up features:

* pager
* color definitions
* mozilla.ircnick
* Bugzilla API Key verification
* evolve
* blackbox
* "review" path

Not sure I'll get all of them in this bug. But I can try.
The blackbox extension provides forensic logging of commands, their
times, and other info useful for debugging performance problems
and how people got to where they are. Countless times I've had to
ask for its output in bug reports only to find out people don't
have it enabled.

So let's offer to enable it.

Review commit: https://reviewboard.mozilla.org/r/59026/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59026/
Attachment #8762172 - Flags: review?(glob)
Attachment #8762173 - Flags: review?(glob)
Attachment #8762174 - Flags: review?(glob)
Lack of pager is IMO one of the most annoying things in a default
Mercurial config.

Enabling the pager extension gets a partially useful pager. But
I feel you have to configure it a bit more, namely enabling it
on other commands and defining a custom `less` invocation to
make it behave better. `less` without -F in particular is quite
annoying because you have to exit the pager for every command,
even if it prints a single line of output!

The config added in this commit mostly matches my local config.
I think it is a good starting point.

Review commit: https://reviewboard.mozilla.org/r/59028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59028/
We recently removed the automagical "review" path from firefoxtree
(bug 1275122). Let's make it explicit by having the config wizard
prompt for it.

This code isn't perfect: we won't prompt to add the "review" path
if we've already run the wizard once. The whole code review
setup workflow needs some love.

Review commit: https://reviewboard.mozilla.org/r/59030/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59030/
Comment on attachment 8762174 [details]
configwizard: prompt to configure the "review" path (bug 1279596);

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59030/diff/1-2/
Comment on attachment 8762172 [details]
configwizard: prompt to enable blackbox extension (bug 1279596);

https://reviewboard.mozilla.org/r/59026/#review56260
Attachment #8762172 - Flags: review?(glob) → review+
Comment on attachment 8762173 [details]
configwizard: prompt to enable and configure pager (bug 1279596);

https://reviewboard.mozilla.org/r/59028/#review56262
Attachment #8762173 - Flags: review?(glob) → review+
Attachment #8762174 - Flags: review?(glob) → review+
Comment on attachment 8762174 [details]
configwizard: prompt to configure the "review" path (bug 1279596);

https://reviewboard.mozilla.org/r/59030/#review56264
Comment on attachment 8762181 [details]
configwizard: prompt to enable curses interfaces (bug 1279596);

https://reviewboard.mozilla.org/r/59032/#review56266

fix issue on commit please.

::: hgext/configwizard/__init__.py:542
(Diff revision 1)
> +            try:
> +                import wcurses
> +            except Exception:
> +                return
> +
> +    if ui.promptchoice(CURSES_INFO):

this should be uipromptchoice() not ui.promptchoice().
Attachment #8762181 - Flags: review?(glob) → review+
Will file more bugs for additional features.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Component: General → Mercurial: configwizard
Blocks: 1284948
Blocks: 1284952
Blocks: 1242994
You need to log in before you can comment on or make changes to this bug.