1279628 - Add the CoreGraphics check from gfxASurface::CheckSurfaceSize to Factory::CheckSurfaceSize, then kill of the latter helper

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: part 1 - Add the CoreGraphics check from gfxASurface::CheckSurfaceSize to Factory::CheckSurfaceSize

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: part 2 - Replace all gfxASurface::CheckSurfaceSize calls with Factory::CheckSurfaceSize and remove gfxASurface::CheckSurfaceSize

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/416fa9aeec55
part 1 - Add the CoreGraphics check from gfxASurface::CheckSurfaceSize to Factory::CheckSurfaceSize. r=mstange
https://hg.mozilla.org/integration/mozilla-inbound/rev/07e4432bd6b3
part 2 - Replace all gfxASurface::CheckSurfaceSize calls with Factory::CheckSurfaceSize and remove gfxASurface::CheckSurfaceSize. r=mstange

Comment 4

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/72577f72121a09977fdf229b720f2a15c4597365 for tons of reftest bustage.

Comment 5

[Jonathan Watt [:jwatt]]

Turns out this is due to the change in CanvasRenderingContext2D::DrawWindow, and it happens because there's one significant difference between gfxASurface::CheckSurfaceSize and Factory::CheckSurfaceSize - the former returns false if the width/height are less than zero, whereas the latter returns false if the width/height are less than or equal to zero.

I'll split the CanvasRenderingContext2D::DrawWindow change out into a 'part 3' patch, and add an explicit check for zero width/height to it before calling Factory::CheckSurfaceSize.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a643f56f7523
part 1 - Add the CoreGraphics check from gfxASurface::CheckSurfaceSize to Factory::CheckSurfaceSize. r=mstange

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/56154813d29d
part 2 - Switch all but one of the gfxASurface::CheckSurfaceSize calls to call Factory::CheckSurfaceSize. r=mstange

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/47c5f6b6fc0f
part 3 - Replace the last gfxASurface::CheckSurfaceSize call, and remove gfxASurface::CheckSurfaceSize. r=mstange

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a643f56f7523
https://hg.mozilla.org/mozilla-central/rev/56154813d29d
https://hg.mozilla.org/mozilla-central/rev/47c5f6b6fc0f