Closed Bug 1279629 Opened 8 years ago Closed 8 years ago

Make `CallArgs` simple enough for rust-bindgen to understand

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1270076

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file)

rust-bindgen doesn't understand templates with value parameters, so this removes
their usage from CallArgs and CallArgsBase.

This upstreams and rebases the following commit from servo/mozjs:

    f671022 Make CallArgs simple enough for bindgen to understand
Comment on attachment 8762196 [details] [diff] [review]
Make `CallArgs` simple enough for rust-bindgen to understand

Review of attachment 8762196 [details] [diff] [review]:
-----------------------------------------------------------------

While this makes sense to me, I'm not sure my C++-fu is strong enough to review this. (FWIW, I think the new version is easier to follow, I'm more worried about missing something exceedingly clever about the old version.)
Attachment #8762196 - Flags: review?(till) → review?(luke)
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0babd9a25eb5
Assignee: nobody → nfitzgerald
Blocks: 1277341
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Attachment #8762196 - Flags: review?(luke)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: