1279633 - Define AsmJSCache_MIN in terms of AsmJSCacheSuccess, instead of the other way around

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

rust-bindgen will make an enum variant for the first definition it encounters,
and then define duplicates as constants outside of the enum definition. This has
the unfortunate effect of making AsmJSCache_MIN an enum variant and
AsmJSCache_Success the constant definition outside of the enum in the case of
the AsmJSCacheResult enumeration. This commit rectifies that.

This upstreams the following commit from servo/mozjs:

    50f47cf Bind AsmJSCache_Success rather than AsmJSCache_MIN

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Define AsmJSCache_MIN in terms of AsmJSCacheSuccess, instead of the other way around

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1657cd50169e

Comment 3

[Till Schneidereit [:till]]

Comment on attachment 8762202 [details] [diff] [review]
Define AsmJSCache_MIN in terms of AsmJSCacheSuccess, instead of the other way around

Review of attachment 8762202 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1722ce2542a
Define AsmJSCache_MIN in terms of AsmJSCacheSuccess, instead of the other way around; r=till

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d1722ce2542a