Closed Bug 1279633 Opened 7 years ago Closed 7 years ago

Define AsmJSCache_MIN in terms of AsmJSCacheSuccess, instead of the other way around

Categories

(Core :: JavaScript Engine, defect, P1)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Iteration:
50.1 - Jun 20
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file)

Define AsmJSCache_MIN in terms of AsmJSCacheSuccess, instead of the other way around
1.59 KB, patch
till
: review+
Details | Diff | Splinter Review 
rust-bindgen will make an enum variant for the first definition it encounters,
and then define duplicates as constants outside of the enum definition. This has
the unfortunate effect of making AsmJSCache_MIN an enum variant and
AsmJSCache_Success the constant definition outside of the enum in the case of
the AsmJSCacheResult enumeration. This commit rectifies that.

This upstreams the following commit from servo/mozjs:

    50f47cf Bind AsmJSCache_Success rather than AsmJSCache_MIN
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1657cd50169e
Assignee: nobody → nfitzgerald
Blocks: 1277341
Status: NEW → ASSIGNED
Blocks: 1263289
Iteration: --- → 50.1
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html]
Comment on attachment 8762202 [details] [diff] [review]
Define AsmJSCache_MIN in terms of AsmJSCacheSuccess, instead of the other way around

Review of attachment 8762202 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8762202 - Flags: review?(till) → review+
Pushed by nfitzgerald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1722ce2542a
Define AsmJSCache_MIN in terms of AsmJSCacheSuccess, instead of the other way around; r=till
https://hg.mozilla.org/mozilla-central/rev/d1722ce2542a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Whiteboard: [devtools-html]
Depends on: 1333245
No longer depends on: 1333245
You need to log in before you can comment on or make changes to this bug.