Closed
Bug 1279657
Opened 8 years ago
Closed 8 years ago
gfx/gl style fixes
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: jgilbert, Assigned: jgilbert)
Details
Attachments
(1 file, 2 obsolete files)
There's still a bunch of star-to-the-right and even one &-to-the-right around. Also we should really be using pointers for outvars, not non-const references, as this makes it clear at the call-site that we expect the value to be mutated.
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/59066/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/59066/
Attachment #8762248 -
Flags: review?(jmuizelaar)
Attachment #8762249 -
Flags: review?(jmuizelaar)
Attachment #8762250 -
Flags: review?(bgirard)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/59068/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/59068/
|
|
Assignee | |
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/59070/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/59070/
|
||
Updated•8 years ago
|
Attachment #8762250 -
Flags: review?(bgirard) → review+
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8762250 [details] Bug 1279657 - failureId outvar should be a pointer. - https://reviewboard.mozilla.org/r/59070/#review56180
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8762248 [details] Bug 1279657 - Fix missed callsites. - https://reviewboard.mozilla.org/r/59066/#review56572
Attachment #8762248 -
Flags: review?(jmuizelaar) → review+
|
|
||
Updated•8 years ago
|
Attachment #8762249 -
Flags: review?(jmuizelaar) → review+
|
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8762249 [details] Bug 1279657 - Star to left against type. - https://reviewboard.mozilla.org/r/59068/#review56574
Pushed by jgilbert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a95a934791f7 Reference declarations should have the & against the type. - r=jrmuizel https://hg.mozilla.org/integration/mozilla-inbound/rev/dfe70885c37c Star to left against type. - r=jrmuizel https://hg.mozilla.org/integration/mozilla-inbound/rev/097dc302f5a0 failureId outvar should be a pointer. - r=benwa
|
||
Comment 8•8 years ago
|
||
sorry had to back this out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=30257344&repo=mozilla-inbound
Flags: needinfo?(jgilbert)
Backout by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f35bb53a6234 Backed out changeset 097dc302f5a0 https://hg.mozilla.org/integration/mozilla-inbound/rev/7acb2ff37250 Backed out changeset dfe70885c37c https://hg.mozilla.org/integration/mozilla-inbound/rev/3295fa46d4ff Backed out changeset a95a934791f7 for bustage on a CLOSED TREE
|
|
Assignee | |
Comment 10•8 years ago
|
||
Comment on attachment 8762248 [details] Bug 1279657 - Fix missed callsites. - Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59066/diff/1-2/
Attachment #8762248 -
Attachment description: Bug 1279657 - Reference declarations should have the & against the type. - → Bug 1279657 - Fix missed callsites. -
Attachment #8762248 -
Flags: review+ → review?(bgirard)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8762249 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8762250 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 11•8 years ago
|
||
Comment on attachment 8762248 [details] Bug 1279657 - Fix missed callsites. - Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59066/diff/2-3/
|
|
||
Comment 12•8 years ago
|
||
Comment on attachment 8762248 [details] Bug 1279657 - Fix missed callsites. - https://reviewboard.mozilla.org/r/59066/#review56974
Attachment #8762248 -
Flags: review+
|
||
Comment 13•8 years ago
|
||
Pushed by jgilbert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ad9c137eb441 Reference declarations should have the & against the type. - r=jrmuizel https://hg.mozilla.org/integration/mozilla-inbound/rev/9c693bcd071c Star to left against type. - r=jrmuizel https://hg.mozilla.org/integration/mozilla-inbound/rev/aa737095008d failureId outvar should be a pointer. - r=benwa https://hg.mozilla.org/integration/mozilla-inbound/rev/fcd860b7546f Fix missed callsites. - r=jrmuizel
|
|
||
Comment 14•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ad9c137eb441 https://hg.mozilla.org/mozilla-central/rev/9c693bcd071c https://hg.mozilla.org/mozilla-central/rev/aa737095008d https://hg.mozilla.org/mozilla-central/rev/fcd860b7546f
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
|
|
Assignee | |
Updated•8 years ago
|
Flags: needinfo?(jgilbert)
Attachment #8762248 -
Flags: review?(bgirard)
You need to log in
before you can comment on or make changes to this bug.
Description
•