1279672 - WebExtension icon does not update on restart in FF47

Status: RESOLVED WONTFIX

(WebExtensions :: Untriaged, defect)

Description

[erosman [:erosman]]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160604131506

Steps to reproduce:

FF47.0
I changed the icon set for the WebExtension addon and restarted the Firefox but it is still showing the previous icon set in contextmenu and about:addons. I disabled/enabled but no change.
I did not test with uninstall.


PS. 
Previous bug regarding the icon not appearing in FF45-46; is fixed in FF47.
Previous bug regarding item not removed on disable in FF45-46; is still present in FF47.
Previous bug regarding the menu not hiding properly based on contexts, not in FF45, appeared in FF46; is still present in FF47.

Comment 1

[Loic]

WebExtensions is meant to be stable with FF48. Did you test your extension with FF48 (or later) because many bugs have been fixed. And what's your extension?

Comment 2

[erosman [:erosman]]

I posted since I noticed it in FF47. It may have been fixed in FF48 or may have not. That all depends on whether the issue has been known or not.
I did not test it with FF48 (as the post indicates).
My extension is not published. I have been testing out WebEx.

Comment 3

[Andrew Swan [:aswan]]

We need some more information here.

Is your extension signed?  How exactly is it installed?  And how did you change the icon?  Did you change the manifest to reference a new icon or just change the contents of the icon file?

Comment 4

[erosman [:erosman]]

More info... 

Signed:
it is in development and has not been submitted to AMO for signing. However, I fail to see how it would be a factor.

Installation: 
Addon is in development and resides on my computer. As with all my under-development addons, it is installed via a reference placed in the
C:\Users\******\AppData\Roaming\Mozilla\Firefox\Profiles\**********.default\extensions 

Icons: 
icons are placed in /icon

manifest.json:
 
  "icons": {
    "16": "icon/icon16.png",
    "32": "icon/icon32.png",
    "64": "icon/icon64.png"
  },


Icons were replaced with different icons using the same name (which in fact is standardised across all my addons)
New icons are different in sizes (ie in KB) comparing to the previous ones.

I have changed icons many times with other types of addons and on restart, new updated icons show.

In fact, the reason for the icon change was that I swapped the icons of this WebExtension addon with another Bootstrapped addon. The bootstrapped addon immediately showed the new icons but the WebExtension addon has not updated its icon yet (even after 50+ restarts).

Logical conclusion:
WebExtensions, cache the icon on install and do not update them at all. In other words, as it is, it requires an uninstall to get the icon updated. Comparing to other types of addon, this is a bug; unless WebExtensions are designed specifically to behave that way.

I hope that is sufficient information however, please let me know if more information is required.

Comment 5

[Loic]

IMHO, you should test your add-on with Beta 48, because the API is more stable.

Kris, any thoughts?

Comment 6

[erosman [:erosman]]

I started experimenting with WebEx from FF45. I mention any issues that I have noticed in the release versions so far. WebEx is still too young and limited for more intensive involvement. ;)

Comment 7

[Kris Maglione [:kmag]]

If you want changes to be picked up, either reload it from about:debugging (see bug 1274576, though) or reinstall it.