1279684 - Once you click "highlight all", you can't go back

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Marco Castelluccio [:marco]]

When you select "Highlight all", the search results are highlighted. If you deselect it, the search results are still highlighted.

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

[Tracking Requested - why for this release]: Regression

Comment 3

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: make sure that toggling 'Highlight All' also hides the found occurrences from the mask

Comment 4

[Mike de Boer [:mikedeboer]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7c87c691761

Comment 5

[Marcia Knous [:marcia]]

Feature has been backed out so not tracking these bugs for 50.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8764920 [details] [diff] [review]
Patch v1: make sure that toggling 'Highlight All' also hides the found occurrences from the mask

Review of attachment 8764920 [details] [diff] [review]:
-----------------------------------------------------------------

please use mozreview when requesting reviews.

::: toolkit/modules/tests/browser/browser_FinderHighlighter.js
@@ +286,5 @@
> +      removeCalls: [1, 2]
> +    };
> +    let promise = promiseTestHighlighterOutput(browser, word, expectedResult);
> +    yield promiseEnterStringIntoFindField(findbar, word);
> +    yield promise;

please use a more descriptive name here than `promise`

Comment 7

[Mike de Boer [:mikedeboer]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6)
> please use mozreview when requesting reviews.

I'd love to, but when you block review request during your PTO, the pushes get blocked, leaving me no place to attach my work to.

Comment 8

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1279684 - make sure that toggling 'Highlight All' also hides the found occurrences from the mask.

Review commit: https://reviewboard.mozilla.org/r/62672/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62672/

Comment 9

[Mike de Boer [:mikedeboer]]

(In reply to Mike de Boer [:mikedeboer] from comment #7)
> I'd love to, but when you block review request during your PTO, the pushes
> get blocked, leaving me no place to attach my work to.

Not meant to sound negative, I'm trying to point out what the downside is to this bugzilla feature... It'd be better, perhaps, if it could be a 'soft' block; as in 'This person is away, are you _sure_ you want to request review?' type of dialog.

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

What's confusing is that I removed the block before you requested review, so I'm not sure why the push was blocked. But I understand now why you went back to Splinter for these patches.

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8768410 [details]
Bug 1279684 - make sure that toggling 'Highlight All' also hides the found occurrences from the mask.

https://reviewboard.mozilla.org/r/62672/#review60186

Sorry for the delay in reviewing.

Comment 12

[Mike de Boer [:mikedeboer]]

https://hg.mozilla.org/integration/fx-team/rev/bb19a9b7a3360dc775dd7f1a88eddff14db8ebe1
Bug 1279684 - make sure that toggling 'Highlight All' also hides the found occurrences from the mask. r=jaws

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bb19a9b7a336

Comment 14

[Alexandru Simonca [:asimonca], Release Desktop QA]

VERIFIED FIXED on Windows 10 x64, Ubuntu 14.04 LTS x64 and OSx 10.9.5 using Firefox DevEdition 50.0a2 (id: 20160804004004)