Closed Bug 1279718 Opened 4 years ago Closed 4 years ago

Remove the sharedPlatform.css

Categories

(Thunderbird :: Theme, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 50.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

Removing the sharedPlatform.css and placing the variables in messenger.css makes it simpler to understand as all variables are together in one file.
Remove it
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8762307 - Flags: review?(acelists)
Is messenger.css applied to all windows/dialogs in TB automatically? Wasn't the point of the shared* files that e.g. addon authors could include it in their dialogs to get the default variables/colors? Or should they now include messenger.css ?
messenger.css is the TB main css file. It's imported everywhere. The sharedPlatform.css was used to implement the FX tabbar stylings but using @import instead of precompile tabmail.css. At this time it was the only file with variables. Now we have also variables in messenger.css.

Most of this variables are added to :root. This means they are also applied on dialogs.
Comment on attachment 8762307 [details] [diff] [review]
no-sharedPlatform.css.patch

Review of attachment 8762307 [details] [diff] [review]:
-----------------------------------------------------------------

OK then.
Attachment #8762307 - Flags: review?(acelists) → review+
https://hg.mozilla.org/comm-central/rev/2e00d024f993
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 50.0
You need to log in before you can comment on or make changes to this bug.