1279718 - Remove the sharedPlatform.css

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

Removing the sharedPlatform.css and placing the variables in messenger.css makes it simpler to understand as all variables are together in one file.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: no-sharedPlatform.css.patch

Remove it

Comment 2

[:aceman]

Is messenger.css applied to all windows/dialogs in TB automatically? Wasn't the point of the shared* files that e.g. addon authors could include it in their dialogs to get the default variables/colors? Or should they now include messenger.css ?

Comment 3

[Richard Marti (:Paenglab)]

messenger.css is the TB main css file. It's imported everywhere. The sharedPlatform.css was used to implement the FX tabbar stylings but using @import instead of precompile tabmail.css. At this time it was the only file with variables. Now we have also variables in messenger.css.

Most of this variables are added to :root. This means they are also applied on dialogs.

Comment 4

[:aceman]

Comment on attachment 8762307 [details] [diff] [review]
no-sharedPlatform.css.patch

Review of attachment 8762307 [details] [diff] [review]:
-----------------------------------------------------------------

OK then.

Comment 5

[Richard Marti (:Paenglab)]

https://hg.mozilla.org/comm-central/rev/2e00d024f993