Fix typos in AddonRepository.jsm and PluginProvider.jsm

RESOLVED FIXED in Firefox 50

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: Nomis101, Assigned: Nomis101)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8762317 [details] [diff] [review]
Patch

I think there are typos in the code of AddonRepository.jsm and PluginProvider.jsm (if so, I'm wondering how this has ever worked in the first place).
Attachment #8762317 - Flags: review?(rhelmer)
Comment on attachment 8762317 [details] [diff] [review]
Patch

Review of attachment 8762317 [details] [diff] [review]:
-----------------------------------------------------------------

Hm, you're correct that these are typos - I think the reason it works is because these arguments are totally unused and both functions just return `true` so it doesn't really matter.
Attachment #8762317 - Flags: review?(rhelmer) → review+
Do you need me to land this?
Flags: needinfo?(Nomis101)
(Assignee)

Comment 3

2 years ago
(In reply to Robert Helmer [:rhelmer] from comment #2)
> Do you need me to land this?

This would be nice, otherwise I would set the checkin-needed flag.
Flags: needinfo?(Nomis101)
Assignee: nobody → Nomis101
Sorry for the delay, lost track of this one. I'll land it for you today.
(In reply to Robert Helmer [:rhelmer] from comment #4)
> Sorry for the delay, lost track of this one. I'll land it for you today.

Actually just going to do what I should've done in the first place and use [checkin-needed] :)
Keywords: checkin-needed

Comment 6

a year ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/e731d2612011
"Fix typos in AddonRepository.jsm and PluginProvider.jsm". r=rhelmer
Keywords: checkin-needed

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e731d2612011
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.