Closed
Bug 1279738
Opened 9 years ago
Closed 9 years ago
Chatzilla Startup preferences not working in Seamonkey
Categories
(SeaMonkey :: General, defect)
Tracking
(seamonkey2.43 unaffected, seamonkey2.44 unaffected, seamonkey2.45 fixed, seamonkey2.46 fixed, seamonkey2.47 fixed)
RESOLVED
FIXED
seamonkey2.45
Tracking | Status | |
---|---|---|
seamonkey2.43 | --- | unaffected |
seamonkey2.44 | --- | unaffected |
seamonkey2.45 | --- | fixed |
seamonkey2.46 | --- | fixed |
seamonkey2.47 | --- | fixed |
People
(Reporter: frg, Assigned: frg)
References
Details
Attachments
(1 file, 1 obsolete file)
1.69 KB,
patch
|
frg
:
review+
|
Details | Diff | Splinter Review |
Starting with Seamonkey 2.45 the following error can be seen in the web console during Chatzilla startup:
>> Timestamp: 6/8/2016 1:52:54 PM
>> Error: TypeError: invalid 'in' operand window.arguments[0]
>> Source File: chrome://chatzilla/content/static.js
>> Line: 795
The startup settings are subsequently ignored.
Starting Chatzilla in a tab or with an url via a link eg. the one on http://www.seamonkey-project.org/community works.
The problem is that bug 1255354 added an additional args parameter for the dialog in the function toOpenWindowByType in suite/common/tasksOverlay.js. The parameter is uninitialized.
![]() |
Assignee | |
Comment 1•9 years ago
|
||
Needs to be pushed to c-c, c-a and c-b if ok. I thought about putting the dialog feature parms in a variable but with just one duplicate line and also nearby in case someone changes this I thought it's not worth it.
[Approval Request Comment]
Regression caused by (bug #): 1255354
User impact if declined: Chatzilla startup preferences not working.
Testing completed (on m-c, etc.): c-b to c-c
Risk to taking this patch (and alternatives if risky): none already broken.
String changes made by this patch: none
[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Testing completed (on m-c, etc.):
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:
Needs to be pushed to c-c, c-a and c-b if ok.
Attachment #8762371 -
Flags: review?(philip.chee)
Attachment #8762371 -
Flags: approval-comm-beta?
Attachment #8762371 -
Flags: approval-comm-aurora?
![]() |
||
Updated•9 years ago
|
Attachment #8762371 -
Flags: review?(philip.chee)
Attachment #8762371 -
Flags: review+
Attachment #8762371 -
Flags: approval-comm-beta?
Attachment #8762371 -
Flags: approval-comm-beta+
Attachment #8762371 -
Flags: approval-comm-aurora?
Attachment #8762371 -
Flags: approval-comm-aurora+
![]() |
||
Comment 2•9 years ago
|
||
Comment on attachment 8762371 [details] [diff] [review]
1279738-chatzilla-startup.patch
r=me a=me
> + if (args) {
> + window[uri] = openDialog(uri, "",
> + features || "non-private,all,dialog=no",
> + args || null);
If (args) is truth-like then it can't be null, no?
![]() |
Assignee | |
Comment 3•9 years ago
|
||
Patch with small change to argument checking as discussed on IRC. Review+ and Approval for c-b and c-a from Philip Chee carried forward.
Attachment #8762371 -
Attachment is obsolete: true
Attachment #8763214 -
Flags: review+
![]() |
Assignee | |
Comment 4•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/604bda922be6
https://hg.mozilla.org/releases/comm-aurora/rev/f78998dd2482
https://hg.mozilla.org/releases/comm-beta/rev/af41a155226f
Case closed.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•