Closed Bug 1279741 Opened 4 years ago Closed 4 years ago

close Contacts sidebar in test-send-button.js

Categories

(Thunderbird :: Testing Infrastructure, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 50.0

People

(Reporter: aceman, Assigned: aceman)

Details

Attachments

(1 file)

812 bytes, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review
We open the Contacts sidebar in compose window in test-send-button.js and never closed. So the sidebar is then opened whenever we open new windows in subsequent tests thus slowing them down unnecessarily.
Attached patch patchSplinter Review
Attachment #8762324 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8762324 [details] [diff] [review]
patch

Review of attachment 8762324 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable. I trust you tested it ;-)
Attachment #8762324 - Flags: review?(mkmelin+mozilla) → review+
https://hg.mozilla.org/comm-central/rev/75903a87a16606c0132c1185b8aa412ec044ba49

Sure, visual observing how the tests run.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 50.0
You need to log in before you can comment on or make changes to this bug.