Closed Bug 1279742 Opened 3 years ago Closed 3 years ago

"Highlight All" dim is scaled when page has horizontal scroll bar.

Categories

(Toolkit :: Find Toolbar, defect)

50 Branch
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla52
Tracking Status
firefox49 --- unaffected
firefox50 + disabled
firefox51 --- disabled
firefox52 --- verified

People

(Reporter: arai, Assigned: mikedeboer)

References

Details

(Keywords: nightly-community, regression, testcase)

Attachments

(3 files, 1 obsolete file)

When a page is wider than the window and has horizontal scrolllbar,
dim of Highlight All is scaled

Steps to reproduce:
  1. make the width of browser window less than 2000px
  2. load attached HTML
  3. search "TEST"
  4. Click "Highlight All"

Actual result:
  Dim is scaled and doesn't match to actual words in the page

Expected result:
  Dim is not scaled and cover entire page
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
I will start using MozReview soon, I promise. :/
Attachment #8762508 - Flags: review?(jaws)
Duplicate of this bug: 1279721
Duplicate of this bug: 1279719
Comment on attachment 8762508 [details] [diff] [review]
Patch v1: render the highlighter mask using plain HTML and CSS

I need to take care of a few more details here.
Attachment #8762508 - Flags: review?(jaws)
Attachment #8762508 - Attachment is obsolete: true
Attachment #8762665 - Flags: review?(jaws)
Blocks: 1279717
[Tracking Requested - why for this release]: Regression
Keywords: regression
Version: unspecified → 50 Branch
Blocks: 1279715
Comment on attachment 8762665 [details] [diff] [review]
Patch v2: render the highlighter mask using plain HTML and CSS

Review of attachment 8762665 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/modules/FinderHighlighter.jsm
@@ +77,2 @@
>  }`;
>  const kSVGNS = "http://www.w3.org/2000/svg";

Looks like kSVGNS can be removed, also in _modalHighlight there is another reference to SVG that is no longer correct with this patch.
Attachment #8762665 - Flags: review?(jaws) → review+
https://hg.mozilla.org/integration/fx-team/rev/ccae8d5e75869480d64882bc6f797e3433a8d00c
Bug 1279742 - render the highlighter mask using plain HTML and CSS, instead of an SVG document. This improves performance and solves various layouting issues. r=jaws
Blocks: 1279752
Blocks: 1279710
Blocks: 1279682
Blocks: 1280149
No longer blocks: 1279752
Duplicate of this bug: 1279752
https://hg.mozilla.org/mozilla-central/rev/ccae8d5e7586
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Tracking 50+ for this scaling regression.
Flags: qe-verify+
Target Milestone: mozilla50 → mozilla52
Reproduced the initial issue using Nightly 50.0a1 (Build ID: 20160611030214) on Windows 10. 

Verified fixed using the latest Nightly 52.0a1 (Build ID: 20160928030201) on Windows 10 x64bit, Ubuntu 16.04 and Mac OS X 10.11.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.