1279742 - "Highlight All" dim is scaled when page has horizontal scroll bar.

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Tooru Fujisawa [:arai]]

Attachment: Test page with width: 2000px

When a page is wider than the window and has horizontal scrolllbar,
dim of Highlight All is scaled

Steps to reproduce:
  1. make the width of browser window less than 2000px
  2. load attached HTML
  3. search "TEST"
  4. Click "Highlight All"

Actual result:
  Dim is scaled and doesn't match to actual words in the page

Expected result:
  Dim is not scaled and cover entire page

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: screenshot of scaled dim

Comment 2

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: render the highlighter mask using plain HTML and CSS

I will start using MozReview soon, I promise. :/

Comment 5

[Mike de Boer [:mikedeboer]]

Comment on attachment 8762508 [details] [diff] [review]
Patch v1: render the highlighter mask using plain HTML and CSS

I need to take care of a few more details here.

Comment 6

[Mike de Boer [:mikedeboer]]

Attachment: Patch v2: render the highlighter mask using plain HTML and CSS

Comment 7

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

[Tracking Requested - why for this release]: Regression

Comment 8

[Mike de Boer [:mikedeboer]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdbcf88a5293

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8762665 [details] [diff] [review]
Patch v2: render the highlighter mask using plain HTML and CSS

Review of attachment 8762665 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/modules/FinderHighlighter.jsm
@@ +77,2 @@
>  }`;
>  const kSVGNS = "http://www.w3.org/2000/svg";

Looks like kSVGNS can be removed, also in _modalHighlight there is another reference to SVG that is no longer correct with this patch.

Comment 10

[Mike de Boer [:mikedeboer]]

https://hg.mozilla.org/integration/fx-team/rev/ccae8d5e75869480d64882bc6f797e3433a8d00c
Bug 1279742 - render the highlighter mask using plain HTML and CSS, instead of an SVG document. This improves performance and solves various layouting issues. r=jaws

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ccae8d5e7586

Comment 13

[Marcia Knous [:marcia]]

Tracking 50+ for this scaling regression.

Comment 14

[Simona Badau, Desktop QA]

Reproduced the initial issue using Nightly 50.0a1 (Build ID: 20160611030214) on Windows 10. 

Verified fixed using the latest Nightly 52.0a1 (Build ID: 20160928030201) on Windows 10 x64bit, Ubuntu 16.04 and Mac OS X 10.11.