Closed
Bug 1279761
Opened 8 years ago
Closed 8 years ago
IonMonkey: MIPS: Implement MCopySign
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: hev, Assigned: hev)
Details
Attachments
(1 file)
|
4.27 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8762356 -
Flags: review?(bbouvier)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8762356 [details] [diff] [review] 0001-Bug-1279761-IonMonkey-MIPS-Implement-MCopySign.-r-bb.patch Review of attachment 8762356 [details] [diff] [review]: ----------------------------------------------------------------- Looks great. Thank you for the patch, as usual! ::: js/src/jit/mips-shared/CodeGenerator-mips-shared.cpp @@ +1441,5 @@ > + masm.as_ins(rhsi, lhsi, 0, 31); > + > + // Reconstruct the output. > + masm.moveFloat32(lhs, output); > + masm.moveToDoubleHi(rhsi, output); It's nice that MIPS has moveToDoubleHi. I think for LCopySignD, you could in Lowering use defineReuseInput to avoid the spurious move lhs -> output, but it's probably simpler this way.
Attachment #8762356 -
Flags: review?(bbouvier) → review+
Pushed by r@hev.cc: https://hg.mozilla.org/integration/mozilla-inbound/rev/0884b0edc65f IonMonkey: MIPS: Implement MCopySign. r=bbouvier
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0884b0edc65f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•