1279805 - Add UTM information to the "What's new?" link in the about dialog

Status: RESOLVED FIXED

(Firefox :: Menus, defect, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

In bug 1047395, we added a link to the release notes from the about dialog, we should add some trackers to have an idea of the usage of this link.

This should probably be added here:
https://dxr.mozilla.org/mozilla-central/source/browser/base/content/aboutDialog.xul#50
We might create a new link in firefox.js

Comment 1

[dindrala]

Hi Sylvestre!

I am a first time contributor to Mozilla and Id like to work on this bug. 

How do I get this working on my local machine? Do I need to setup/build? Is there a github repo I can pull from to get the code? 

Also, if you could give a little more detail about the bug and how to approach it I think that will be really helpful.

Really excited to get my 1st Mozilla ticket!

Let me know!

Cheers!

Comment 2

[Paul Bignier]

Hello dindrala,

I have already started on this.
Here's the info for getting started with the repo & workflow, whether you're using git or hg: https://developer.mozilla.org/en-US/docs/Mozilla/Git

Regards,
Paul

Comment 3

[dindrala]

Hey Paul,

Apologies! The ticket says and still does say it isn't assigned to anyone.

Thank you for the work flow information.

Cheers!

Comment 4

[Paul Bignier]

Attachment: 0001-Bug-1279805-fixed-Add-UTM-info-to-the-What-s-new-lin.patch

Comment 5

[Paul Bignier]

Hello Gareth,

What do you think about my proposal? I wans't sure what to put into utm_campaign.
Sylvestre, could you please specify what you would like in firefox.js? I don't know which pref value to set.

Regards,
Paul

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8763498 [details] [diff] [review]
0001-Bug-1279805-fixed-Add-UTM-info-to-the-What-s-new-lin.patch

Chris, can you help with that? Or could you redirect to a better person if needed? Thanks

Comment 7

[Gareth Cull [:garethc]]

Hey Guys,

If you want to add utm parameters to whatsnew when it loads, can you please append the following:
?utm_source=firefox-browser&utm_medium=firefox-browser&utm_campaign=whatsnew

Gareth

Comment 8

[Paul Bignier]

Attachment: 0001-Bug-1279805-fixed-Add-UTM-info-to-the-What-s-new-lin.patch

> If you want to add utm parameters to whatsnew when it loads, can you please append the following

Done, thank you for the tip!

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Chris, can you help with this? Thanks

Comment 10

[Chris More [:cmore]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #9)
> Chris, can you help with this? Thanks

Sure! What do you need me to me to do? :)

Comment 11

[Chris More [:cmore]]

:garethc: can you help here with UTM parameters? We'll probably want to make sure stick with similar UTM parameters we use within the product.

Comment 12

[Matthew N. [:MattN]]

Comment on attachment 8775582 [details] [diff] [review]
0001-Bug-1279805-fixed-Add-UTM-info-to-the-What-s-new-lin.patch

Review of attachment 8775582 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Paul,

I'll steal this review since I don't think Gareth is the right person anyways. While your patch is correct, the approach from bug 1047395 was wrong IMO as it didn't take the advice in bug 1047395 comment 1 and so we're currently hard-coding this Mozilla URL unofficial/third-party builds. Since that's not your fault I'll just make a patch to fix this properly.

Comment 13

[Matthew N. [:MattN]]

Attachment: Bug 1279805 - Use app.releaseNotesURL to control release notes in the about dialog.

Review commit: https://reviewboard.mozilla.org/r/128654/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128654/

Comment 14

[Matthew N. [:MattN]]

Attachment: Bug 1279805 - Add UTM information to the release notes link from the browser.

Review commit: https://reviewboard.mozilla.org/r/128656/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128656/

Comment 15

[Florian Quèze [:florian]]

Comment on attachment 8856737 [details]
Bug 1279805 - Use app.releaseNotesURL to control release notes in the about dialog.

https://reviewboard.mozilla.org/r/128654/#review131324

Comment 16

[Florian Quèze [:florian]]

Comment on attachment 8856738 [details]
Bug 1279805 - Add UTM information to the release notes link from the browser.

https://reviewboard.mozilla.org/r/128656/#review131326

Comment 17

[Matthew N. [:MattN]]

Thanks

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b34015dd0554
Use app.releaseNotesURL to control release notes in the about dialog. r=florian
https://hg.mozilla.org/integration/autoland/rev/e7efcfe485de
Add UTM information to the release notes link from the browser. r=florian

Comment 19

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/b34015dd0554
https://hg.mozilla.org/mozilla-central/rev/e7efcfe485de