1279807 - History panel smartfolder icons are much too big on HDPI devices

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Jan Henning [:JanH]]

Attachment: smart folder icons without scaling on an HDPI device.png

Because the history panel smartfolder icons are nodpi-resources and we also stopped scaling them in bug 1279336, they're now much too big on non-XXHDPI devices, e.g. my HDPI-phone (see attachement).

Comment 1

[Chenxia Liu [:liuche]]

Ah, okay, I had forgotten about how nodpi worked. We should do is either use dimensions for each type of icon, or include all the icons - but it's better to include all the dimensions, rather than all the icons.

Comment 2

[Chenxia Liu [:liuche]]

Attachment: Bug 1279807 - History panel smartfolder icons are much too big on HDPI devices.

Review commit: https://reviewboard.mozilla.org/r/59292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59292/

Comment 3

[Chenxia Liu [:liuche]]

From antlam:
clock icon: 18x18dp
cloud icon: 26x18dp

Comment 4

[Jan Henning [:JanH]]

Comment on attachment 8762842 [details]
Bug 1279807 - History panel smartfolder icons are much too big on HDPI devices.

https://reviewboard.mozilla.org/r/59292/#review56312

I trust you to know more about the correct way to scale those icons than me, but speaking empirically, they're looking fine now on my phone.

Comment 5

[Jan Henning [:JanH]]

Attachment: smart folder icons with scaling on an HDPI device.png

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/0320069de389
History panel smartfolder icons are much too big on HDPI devices. r=JanH

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0320069de389

Comment 8

[Sorina Florean [:sflorean]]

Verified as fixed in build 50.0a1 (2016-06-16);
Device: 
- Asus ZenPad 8 (Android 5.0.2);
- Prestigio Grace X5 (Android 4.4.2);
- Motorola Razr (Android 4.4.4).