Closed
Bug 1279807
Opened 9 years ago
Closed 9 years ago
History panel smartfolder icons are much too big on HDPI devices
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(firefox47 unaffected, firefox48 unaffected, firefox49 unaffected, firefox50 verified)
VERIFIED
FIXED
Firefox 50
Tracking | Status | |
---|---|---|
firefox47 | --- | unaffected |
firefox48 | --- | unaffected |
firefox49 | --- | unaffected |
firefox50 | --- | verified |
People
(Reporter: JanH, Assigned: liuche)
References
Details
Attachments
(3 files)
Because the history panel smartfolder icons are nodpi-resources and we also stopped scaling them in bug 1279336, they're now much too big on non-XXHDPI devices, e.g. my HDPI-phone (see attachement).
Assignee | ||
Comment 1•9 years ago
|
||
Ah, okay, I had forgotten about how nodpi worked. We should do is either use dimensions for each type of icon, or include all the icons - but it's better to include all the dimensions, rather than all the icons.
Assignee | ||
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/59292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59292/
Attachment #8762842 -
Flags: review?(jh+bugzilla)
Assignee | ||
Comment 3•9 years ago
|
||
From antlam:
clock icon: 18x18dp
cloud icon: 26x18dp
Assignee: nobody → liuche
Reporter | ||
Updated•9 years ago
|
Attachment #8762842 -
Flags: review?(jh+bugzilla) → review+
Reporter | ||
Comment 4•9 years ago
|
||
Comment on attachment 8762842 [details]
Bug 1279807 - History panel smartfolder icons are much too big on HDPI devices.
https://reviewboard.mozilla.org/r/59292/#review56312
I trust you to know more about the correct way to scale those icons than me, but speaking empirically, they're looking fine now on my phone.
Reporter | ||
Comment 5•9 years ago
|
||
Pushed by cliu@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/0320069de389
History panel smartfolder icons are much too big on HDPI devices. r=JanH
Comment 7•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Comment 8•9 years ago
|
||
Verified as fixed in build 50.0a1 (2016-06-16);
Device:
- Asus ZenPad 8 (Android 5.0.2);
- Prestigio Grace X5 (Android 4.4.2);
- Motorola Razr (Android 4.4.4).
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•