1279813 - Handle edge cases in wpt update better

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[James Graham [:jgraham]]

Currently we don't cope very well if there are conflicting results for a test, or if we are trying to update a file with no "expected" value.

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 1279813 - Handle edge cases in wpt update better,

Better support for cases where tests get conflicting results and
where there is no expected value in a manifest.

Review commit: https://reviewboard.mozilla.org/r/59118/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59118/

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8762416 [details]
Bug 1279813 - Handle edge cases in wpt update better,

https://reviewboard.mozilla.org/r/59118/#review56126

::: testing/web-platform/harness/wptrunner/manifestupdate.py:36
(Diff revision 1)
>  new results are known, coalesce_expected is called to compute the new
>  set of results and conditionals. The AST of the underlying parsed manifest
>  is updated with the changes, and the result is serialised to a file.
>  """
>  
> +class ConditionError(Exception):

Document this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/12faf2ec748d
Handle edge cases in wpt update better, r=Ms2ger

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/12faf2ec748d