1279830 - Add content-type to form submission script responses

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[James Graham [:jgraham]]

Otherwise a dialog pops up and badness happens

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 1279830 - Add a content-type to form-submission script response,

Review commit: https://reviewboard.mozilla.org/r/59126/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59126/

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://reviewboard.mozilla.org/r/59126/#review56128

::: testing/web-platform/tests/common/form-submission.py:4
(Diff revision 1)
>  def main(request, response):
>      if request.headers.get('Content-Type') == 'application/x-www-form-urlencoded':
>          if request.body == 'foo=bara':
> -            return 'OK'
> +            return ([("Content-Type", "text/plain")], 'OK')

This duplication kinda sucks... Can you put the string in a local and return it with the headers at the end?

Comment 3

[James Graham [:jgraham]]

Comment on attachment 8762423 [details]
Bug 1279830 - Add a content-type to form-submission script response,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59126/diff/1-2/

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8762423 [details]
Bug 1279830 - Add a content-type to form-submission script response,

https://reviewboard.mozilla.org/r/59126/#review56132

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3841e305b11
Add a content-type to form-submission script response, r=Ms2ger

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d3841e305b11