Closed
Bug 1279833
Opened 9 years ago
Closed 9 years ago
Make less use of gBrowser and content tabs in devtools
Categories
(DevTools :: General, enhancement)
DevTools
General
Tracking
(firefox50 fixed)
RESOLVED
FIXED
Firefox 50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: Fallen, Assigned: Fallen)
References
Details
Attachments
(1 file, 1 obsolete file)
|
10.14 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
In order to reduce the number of shims needed for Thunderbird, I'd like to reduce the use of gBrowser in devtools, mostly by replacing gBrowser.addTab with openUILinkIn.
I also went ahead and made some changes to the eyedropper tool so it works even if there is no content tab to screenshot. This kind of fits into the same area of making devtools less Firefox-specific, if you'd prefer to split these patches let me know.
|
Assignee | |
Comment 1•9 years ago
|
||
This patch depends on bug 1279784, so here is a combined try push.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f61e19d9ed3e
Attachment #8762426 -
Flags: review?(jwalker)
|
||
Updated•9 years ago
|
Attachment #8762426 -
Flags: review?(jwalker) → review+
|
|
Assignee | |
Updated•9 years ago
|
Depends on: 1279784
Keywords: checkin-needed
|
|
Assignee | |
Comment 2•9 years ago
|
||
Debitrotted patch for checkin
Attachment #8762426 -
Attachment is obsolete: true
Attachment #8765800 -
Flags: review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/3f58f958a982
Make less use of gBrowser and content tabs in devtools. r=jwalker
Keywords: checkin-needed
Severity: normal → enhancement
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•