Closed
Bug 1279860
Opened 8 years ago
Closed 8 years ago
Rename nsFormSubmission to mozilla::dom::HTMLFormSubmission
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
Attachments
(4 files, 2 obsolete files)
|
43.15 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
|
4.84 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
|
3.57 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
|
20.42 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Before finishing my work on HTML Form Submission + Directory API, I want to cleanup the code.
Attachment #8762456 -
Flags: review?(bugs)
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8762456 -
Attachment is obsolete: true
Attachment #8762456 -
Flags: review?(bugs)
Attachment #8762458 -
Flags: review?(bugs)
|
||
Updated•8 years ago
|
Attachment #8762458 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 2•8 years ago
|
||
This patch seems huge, but actually I did: 1. nsFSMultipartFormData -> FSMultipartFormData 2. GetSubmissionFromForm -> static GetFromForm in HTMLFormSubmission 3. nsEncodingFormSubmission -> EncodingFormSubmission 4. nsFSURLEncoded -> FSURLEncoded 5. nsFSTextPlain -> FSTextPlain All the classes are marked as final and virtual keyword removed (except for EncodingFormSubmission of course). No real code has been modified.
Attachment #8762461 -
Flags: review?(bugs)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8762458 -
Attachment description: formSubmission1.patch → part 1
|
|
||
Comment 3•8 years ago
|
||
Why are we moving code inside HTMLFormSubmission.cpp?
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8762461 [details] [diff] [review] part 2 makes review hard when renaming and code moves happen at the same time. And I see no reason for code moves.
Attachment #8762461 -
Flags: review?(bugs) → review-
|
|
Assignee | |
Comment 5•8 years ago
|
||
Attachment #8762920 -
Flags: review?(bugs)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8762461 -
Flags: review-
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8762461 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•8 years ago
|
||
Attachment #8762922 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 7•8 years ago
|
||
Attachment #8762925 -
Flags: review?(bugs)
|
|
||
Comment 8•8 years ago
|
||
Comment on attachment 8762920 [details] [diff] [review] part 2 - static methods vs anonymous namespace FYI, Mozilla coding style recommends using static methods and not anonymous namespace. But up to you.
Attachment #8762920 -
Flags: review?(bugs) → review+
|
|
||
Updated•8 years ago
|
Attachment #8762922 -
Flags: review?(bugs) → review+
|
|
||
Updated•8 years ago
|
Attachment #8762925 -
Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cdb0aacd70a3 part 1 - Renaming nsFormSubmission to mozilla::dom::HTMLFormSubmission, r=smaug https://hg.mozilla.org/integration/mozilla-inbound/rev/b8f1b4803048 part 2 - Anonymous namespaces in HTMLFormSubmission, r=smaug https://hg.mozilla.org/integration/mozilla-inbound/rev/6b367f51b366 part 3 - HTMLFormSubmission::GetFromForm, r=smaug https://hg.mozilla.org/integration/mozilla-inbound/rev/62d2c8acb073 part 4 - Renaming FSMultipartFormData and other HTMLFormSubmission classes, r=smaug
|
||
Comment 10•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/cdb0aacd70a3 https://hg.mozilla.org/mozilla-central/rev/b8f1b4803048 https://hg.mozilla.org/mozilla-central/rev/6b367f51b366 https://hg.mozilla.org/mozilla-central/rev/62d2c8acb073
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•