Rename occurrences of "Oriya" to "Odia"

RESOLVED FIXED in Firefox 50

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: flod, Assigned: Towkir, Mentored)

Tracking

unspecified
Firefox 50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
We need to use Odia for 'or'.

As noted in bug 1275476

> I was looking at the code and there are indeed a ton of internal references
> to oriya. 
> 
> I guess it would be safe enough to change the key name and label here, but
> moving away for the value from "x-orya" would prove a lot harder
> http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/
> browser/preferences/fonts.dtd#50
> 
> The other reference is in languageNames.properties
> http://mxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/
> global/languageNames.properties#138
> 
> Also not sure who's familiar with out internationalization code these days.

Comment 1

2 years ago
To fix this bug, all the lines in this query should have "Oriya" replaced with "Odia" (and "oriya" with "odia" in the identifier names):

https://mzl.la/1UO39vQ
Mentor: gijskruitbosch+bugs
Whiteboard: [good first bug]

Comment 2

2 years ago
Hi ! I am a first time contributor to Mozilla Foundations and I would like to work on this bug. 
Do I need to setup/build a software or can I request changes directly to Mozilla-central tree files ?

Is these the four files where changes are needed to be performed ? - fonts.xul,fonts.dtd,languageNames.properties,locale-fonts.nsh

How can I safely make changes to this files ?

Comment 3

2 years ago
Hi ! I am a first time contributor to Mozilla Foundations and I would like to work on this bug. 
Do I need to setup/build a software or can I request changes directly to Mozilla-central tree files ?

Is these the four files where changes are needed to be performed ? - fonts.xul,fonts.dtd,languageNames.properties,locale-fonts.nsh

How can I safely make changes to this files ?

Comment 4

2 years ago
(In reply to Aakanxu Shah from comment #3)
> Hi ! I am a first time contributor to Mozilla Foundations and I would like
> to work on this bug. 

Great!

> Do I need to setup/build a software or can I request changes directly to
> Mozilla-central tree files ?

It would be a good idea to get a local build going to test these changes. See https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Artifact_builds and https://developer.mozilla.org/en-US/docs/Simple_Firefox_build .

> Is these the four files where changes are needed to be performed ? -
> fonts.xul,fonts.dtd,languageNames.properties,locale-fonts.nsh

Yes. Let me know if you need more instructions than the links above. :-)
(Assignee)

Comment 5

2 years ago
(In reply to :Gijs Kruitbosch from comment #1)
> To fix this bug, all the lines in this query should have "Oriya" replaced
> with "Odia" (and "oriya" with "odia" in the identifier names):
> 
> https://mzl.la/1UO39vQ

Looks like a massive change, will submit a patch soon.
Thanks
Assignee: nobody → 3ugzilla
(Assignee)

Comment 6

2 years ago
Hi, Gijs
should it be changed too ?
moriya	M AO R IY AH

https://dxr.mozilla.org/mozilla-central/source/dom/media/webspeech/recognition/models/dict/en-US.dic#80406

if I change moriya to modia what do I do about the 'M AO R IY Ah' ??
Flags: needinfo?(gijskruitbosch+bugs)

Comment 7

2 years ago
(In reply to [:Towkir] Ahmed from comment #6)
> Hi, Gijs
> should it be changed too ?
> moriya	M AO R IY AH
> 
> https://dxr.mozilla.org/mozilla-central/source/dom/media/webspeech/
> recognition/models/dict/en-US.dic#80406
> 
> if I change moriya to modia what do I do about the 'M AO R IY Ah' ??

No, don't change any of that.

The change is not so big at all - but it seems DXR is broken (bug 1282277) and so the link in comment #4 returns way more results than it should. The only changes should be these 4 instances:

https://dxr.mozilla.org/mozilla-central/search?q=oriya+-path%3A*intl*+-path%3A*gfx*+-path%3A*cld2*+-path%3A*pdfjs*+-path%3Adevtools*+-path%3Adom%2F*+-path%3Ajs%2F*+-path%3A*spellcheck*+-path%3Alayout*+-path%3Amodules%2F*+-path%3Anetwerk%2F*+-path%3Aobj-x86*+-path%3Atesting%2F*&redirect=false


Hope that helps, and sorry for the trouble.
Flags: needinfo?(gijskruitbosch+bugs)

Comment 8

2 years ago
Just in case that breaks again:


	browser / components / preferences / fonts.xul
71 	<menuitem value="x-orya"          label="&font.langGroup.oriya;"/>


	browser / locales / en-US / chrome / browser / preferences / fonts.dtd
50 	<!ENTITY  font.langGroup.oriya                    "Oriya">


	toolkit / locales / en-US / chrome / global / languageNames.properties
138 	or = Oriya


	toolkit / mozapps / installer / windows / nsis / locale-fonts.nsh
461 	; Oriya
(Assignee)

Comment 9

2 years ago
Created attachment 8765575 [details] [diff] [review]
renamedoccurrences.patch

Okay, here is the patch. I already modified most of them (almost 500+ from your first link though :p )

Here are the only four now.
Thanks
Attachment #8765575 - Flags: review?(gijskruitbosch+bugs)

Comment 10

2 years ago
Comment on attachment 8765575 [details] [diff] [review]
renamedoccurrences.patch

Review of attachment 8765575 [details] [diff] [review]:
-----------------------------------------------------------------

This looks OK to me. Francesco, can you also take a look? I think we'll just have to swallow the change for languageNames.properties and notify the l10n list, unless you have a better idea?
Attachment #8765575 - Flags: review?(gijskruitbosch+bugs)
Attachment #8765575 - Flags: review?(francesco.lodolo)
Attachment #8765575 - Flags: review+
(Reporter)

Comment 11

2 years ago
Comment on attachment 8765575 [details] [diff] [review]
renamedoccurrences.patch

Review of attachment 8765575 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. 

For languageNames.properties: that's expected, I'll include the change in the email on merge day to make sure all locales are aware of the change.
Attachment #8765575 - Flags: review?(francesco.lodolo) → review+

Comment 12

2 years ago
Thanks!
Keywords: checkin-needed

Comment 13

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/c3f7decce97e
Renamed occurrences of 'Oriya' to 'Odia'. r=gijs
Keywords: checkin-needed

Comment 14

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c3f7decce97e
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50

Updated

2 years ago
Blocks: 1303529
You need to log in before you can comment on or make changes to this bug.