1279911 - Sort not working on XUL tree

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Mark C]

Attachment: xul_tree.zip

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20160511223818

Steps to reproduce:

On Firefox >=46 it is no longer possible to sort the content of a XUL tree (served as Remote XUL) by clicking on the column headers. To reproduce:

1) Install the Remote XUL Manager add-on (restartless).
2) Use the add-on prefs to whitelist "http://twofold-software.com", where I've uploaded a test case.
3) Visit http://twofold-software.com/test/tree.xul
4) Try to sort the columns by clicking on the headers.


I've also attached the test case to this bug, for reference.


Actual results:

With 46 or later, the columns are not sortable.

Using mozregression appears to isolate the cause to a fix for bug #1231828. Relevant output from mozregression below:

2016-06-13T12:57:00: INFO : Narrowed inbound regression window from [303cefb1, d897127c] (4 revisions) to [ec86fd78, d897127c] (2 revisions) (~1 steps left)
2016-06-13T12:57:00: DEBUG : Starting merge handling...
2016-06-13T12:57:00: DEBUG : Using url: https://hg.mozilla.org/integration/mozilla-inbound/json-pushes?changeset=d897127c0000a478c24e29ce10f85837a16450c6&full=1
2016-06-13T12:57:01: DEBUG : Found commit message:
Bug 1231828: Fix JS parsing errors in toolkit and browser XBL files. r=felipe

2016-06-13T12:57:01: INFO : The bisection is done.



Expected results:

The columns should have been sortable. Confirmed as working on Firefox 45.


Note: Although Remote XUL is deprecated, we have a large application that is based on it which can't practically be rewritten until "Web Components" becomes generally available in a release build.

Comment 1

[Neil Deakin]

Looks like the regressing bug added some priviledged calls. But it appears to just need the OS type which it could instead get from navigator.platform.

Essentially, the changes in https://reviewboard.mozilla.org/r/27681/diff/2#index_header to toolkit/content/widgets would need to be changed.

Comment 2

[Mark C]

Today we discovered that this has also caused a regression in Control-click selection of tree rows. Ctrl-clicking on a de-selected row causes any selected rows to become de-selected, rather than adding the clicked row to the selection.

Ctrl-clicking on an already selected row appears to de-select it without affecting any other rows, as expected.


Once again we used mozregression to confirm, and it resulted in the same output as above, fingering the same commit.

Comment 3

[[e-mail]]

Attachment: Proposed patch

Comment 4

[Carsten Book [:Tomcat]]

has problems to apply:

1 out of 2 hunks FAILED -- saving rejects to file toolkit/content/widgets/autocomplete.xml.rej
patching file toolkit/content/widgets/tree.xml
Hunk #3 FAILED at 1408
1 out of 3 hunks FAILED -- saving rejects to file toolkit/content/widgets/tree.xml.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 1279911.diff

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f6194f5a52b
Use content-safe platform detection r=enndeakin

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5f6194f5a52b

Comment 7

[Firefox Bug Husbandry Bot]

Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336