1279977 - We should not expose ParentThreadUnchangedBusyCount

Status: RESOLVED INVALID

(Core :: DOM: Workers, defect, P3)

Description

[Andrea Marchesini [:baku]]

I want to make workerRunnable simpler. This step is about removing ParentThreadUnchangedBusyCount, because it's used only internally and it should not be exposed to the rest of gecko.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: runnable1.patch

Comment 2

[Andrea Marchesini [:baku]]

Jonas, do you want to take this one as well? It's the patch needed for the 2 patches you reviewed about WorkerRunnables.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This seems to contain enough complexity that it's probably better to leave for Kyle.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8762613 [details] [diff] [review]
runnable1.patch

Review of attachment 8762613 [details] [diff] [review]:
-----------------------------------------------------------------

At the very least, you'd need to rename a bunch of things.  TargetAndBusyCountBehavior is not anymore, for instance.

If you really wanted to do this I'd make a private ctor on WorkerRunnable/WorkerControlRunnable (that takes a FriendKey or something) and forbid the use of ParentThreadAndUnchangedBusyCount in the public ctor with an assertion.

Comment 6

[Marion Daly [:mdaly]]

Baku: what should we do with this bug?

Comment 7

[Andrea Marchesini [:baku]]

This bug is invalid. We don't need this change anymore.