Description for SSL_CIPHER_SUITE_* out of date

RESOLVED FIXED in Firefox 55

Status

()

Core
Security: PSM
P5
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: chutten, Unassigned)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [good-first-bug][psm-cleanup])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
The SSL_CIPHER_SUITE_* descriptions in Histograms.json points at nsNSSCallbacks::HandleCallbacks. It should probably point instead at nsNSSCallbacks::AccumulateCipherSuite[0].

[0]: https://dxr.mozilla.org/mozilla-central/rev/b6f7d0eb61b1878d3d906bd231edf225463ece3f/security/manager/ssl/nsNSSCallbacks.cpp#1019
Component: Telemetry → Security: PSM
Product: Toolkit → Core
Priority: -- → P5
Whiteboard: [good-first-bug] → [good-first-bug][psm-cleanup]
(In reply to Chris H-C :chutten from comment #0)
> The SSL_CIPHER_SUITE_* descriptions in Histograms.json points at
> nsNSSCallbacks::HandleCallbacks. It should probably point instead at
> nsNSSCallbacks::AccumulateCipherSuite[0].
> 
> [0]:
> https://dxr.mozilla.org/mozilla-central/rev/
> b6f7d0eb61b1878d3d906bd231edf225463ece3f/security/manager/ssl/nsNSSCallbacks.
> cpp#1019

Those probes [0] are used in the call to nsNSSCallbacks::AccumulateCipherSuite inside nsNSSCallbacks::HandshakeCallback. And yes, the key exchanges seem to live in nsNSSCallbacks::AccumulateCipherSuite.

If this is still due, should I go ahead? 
Is changing the function name (HandshakeCallback) in Histograms.json the only change to be made?

If yes, I'm gonna prepare a patch for it soon. And who I should put as reviewer?

Thanks!


[0]: https://dxr.mozilla.org/mozilla-central/rev/b6f7d0eb61b1878d3d906bd231edf225463ece3f/security/manager/ssl/nsNSSCallbacks.cpp#1079,1115-1118
Comment hidden (mozreview-request)
(Reporter)

Comment 3

a year ago
mozreview-review
Comment on attachment 8851281 [details]
Bug 1279985 - Description for SSL_CIPHER_SUITE_* out of date;

https://reviewboard.mozilla.org/r/123636/#review126316

This is exactly what's needed, and why this is a good first bug. Thanks! I'll have this pushed.
Attachment #8851281 - Flags: review?(chutten) → review+

Comment 4

a year ago
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9a6eebeed904
Description for SSL_CIPHER_SUITE_* out of date; r=chutten

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9a6eebeed904
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.