Closed Bug 1279991 Opened 8 years ago Closed 8 years ago

Use [Func=""] on EventListenerOptions.mozSystemGroup

Categories

(Core :: DOM: Events, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(1 file)

In bug 1274520, we check whether EventListenerOptions.mozSystemGroup is used in chrome code or XBL. This really should make use of the [Func=""] extended attribute on dictionary member added in bug 1277401.
Comment on attachment 8763443 [details]
Bug 1279991 - Use [Func=] for EventTarget.mozSystemGroup.

https://reviewboard.mozilla.org/r/59632/#review58214

::: dom/webidl/EventTarget.webidl
(Diff revision 1)
>  
>  
>  dictionary EventListenerOptions {
>    boolean capture = false;
> -  /* This is a Mozilla extension only available in Chrome and XBL.
> +  [Func="ThreadSafeIsChromeOrXBL"]
> -     Setting to true make the listener be added to the system group. */

Should probably keep this part of the comment.
Attachment #8763443 - Flags: review?(peterv) → review+
Comment on attachment 8763443 [details]
Bug 1279991 - Use [Func=] for EventTarget.mozSystemGroup.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59632/diff/1-2/
Assignee: nobody → xidorn+moz
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d0a326d2194
Use [Func=] for EventTarget.mozSystemGroup. r=peterv
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3d0a326d2194
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.