Closed
Bug 1279998
Opened 8 years ago
Closed 8 years ago
Remove NSCAP_FEATURE_TEST_NONNULL_QUERY_SUCCEEDS
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla51
People
(Reporter: mccr8, Assigned: mccr8)
Details
Attachments
(1 file)
This #define asserts if a QI fails. I can't imagine anybody ever enables this.
|
||
Comment 1•8 years ago
|
||
Yeah, that code would be...noisy if it was enabled, I think.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → continuation
|
|
Assignee | |
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/68348/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/68348/
Attachment #8776641 -
Flags: review?(nfroyd)
|
|
Assignee | |
Comment 3•8 years ago
|
||
Disclaimer: I have not actually built this patch.
|
|
||
Updated•8 years ago
|
Attachment #8776641 -
Flags: review?(nfroyd) → review+
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8776641 [details] Bug 1279998 - Remove NSCAP_FEATURE_TEST_NONNULL_QUERY_SUCCEEDS. https://reviewboard.mozilla.org/r/68348/#review65426 I cannot imagine that turning this on is ever useful; the assertion spam you would get...
|
|
Assignee | |
Comment 5•8 years ago
|
||
I'll try not to think about how much machine time I'm burning for all the people who build Gecko with this patch...
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/23457f1d08df Remove NSCAP_FEATURE_TEST_NONNULL_QUERY_SUCCEEDS. r=froydnj
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/23457f1d08df
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•