this.tabs is undefined when running tests

NEW
Unassigned

Status

()

Firefox
Tabbed Browser
P5
normal
2 years ago
2 years ago

People

(Reporter: gw280, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

I often see the following in my test logs:

JavaScript error: chrome://browser/content/tabbrowser.xml, line 2947: TypeError: this.tabs is undefined

We should probably fix this.

Comment 1

2 years ago
Which tests?
Flags: needinfo?(gwright)
Most of the ones I've looked at the logs for, at least. 

e.g. https://treeherder.mozilla.org/logviewer.html#?job_id=30772070&repo=mozilla-inbound

(line 4006)
Flags: needinfo?(gwright)

Comment 3

2 years ago
(In reply to George Wright (:gw280) (:gwright) from comment #2)
> Most of the ones I've looked at the logs for, at least. 
> 
> e.g.
> https://treeherder.mozilla.org/logviewer.html#?job_id=30772070&repo=mozilla-
> inbound
> 
> (line 4006)

Something's hitting the gBrowser.browsers getter somehow, which runs that code, after the XBL binding has already been shut down (which likely means the window has been closed already, which makes sense because the logs show this as coming up when a test run has finished). To figure out what's happening here we'd need a stack for that error.

I don't think this is terribly high priority if it *is* indeed associated with the window closing, though it might depend on the stack and whether throwing in that particular location is a bad thing or not.
You need to log in before you can comment on or make changes to this bug.