1280099 - Intermittent test_peerConnection_trackDisabling.html | Test timed out.

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://treeherder.mozilla.org/logviewer.html#?job_id=30128179&repo=mozilla-inbound

09:57:03     INFO -  215 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_trackDisabling.html | pcLocal: SDP contains non-zero IP c line
09:57:03     INFO -  216 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_trackDisabling.html | pcLocal: SDP contains rtcp-mux
09:57:03     INFO -  217 INFO Run step 54: PC_REMOTE_VERIFY_SDP_AFTER_END_OF_TRICKLE
09:57:03     INFO -  218 INFO Run step 55: CHECK_ASSUMPTIONS
09:57:03     INFO -  219 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_trackDisabling.html | pcLocal should have one media element
09:57:03     INFO -  220 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_trackDisabling.html | pcRemote should have one media element
09:57:03     INFO -  221 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_trackDisabling.html | pcLocal should have one stream
09:57:03     INFO -  222 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_trackDisabling.html | pcRemote should have one stream
09:57:03     INFO -  223 INFO Run step 56: CHECK_VIDEO
09:57:03     INFO -  224 INFO Checking local video enabled
09:57:03     INFO -  225 INFO Checking remote video enabled
09:57:03     INFO -  226 INFO Disabling original
09:57:03     INFO -  227 INFO Checking local video disabled
09:57:03     INFO -  228 INFO Checking remote video disabled
09:57:03     INFO -  229 INFO Run step 57: CHECK_AUDIO
09:57:03     INFO -  230 INFO Checking local audio enabled
09:57:03     INFO -  231 INFO Checking remote audio enabled
09:57:03     INFO -  232 INFO Checking local audio disabled
09:57:03     INFO -  233 INFO Checking remote audio disabled
09:57:03     INFO -  234 INFO TEST-UNEXPECTED-FAIL | dom/media/tests/mochitest/test_peerConnection_trackDisabling.html | Test timed out.
09:57:03     INFO -      reportError@SimpleTest/TestRunner.js:114:7
09:57:03     INFO -      TestRunner._checkForHangs@SimpleTest/TestRunner.js:135:7
09:57:03     INFO -  235 INFO Closing peer connections

Comment 1

[Intermittent Failures Robot]

5 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 4
* fx-team: 1

Platform breakdown:
* android-4-3-armv7-api15: 3
* windows7-32-vm: 1
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1280099&startday=2016-07-04&endday=2016-07-10&tree=all

Comment 2

[Intermittent Failures Robot]

16 failures in 526 pushes (0.03 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 7
* mozilla-central: 4
* autoland: 4
* try: 1

Platform breakdown:
* linux64: 15
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1280099&startday=2016-12-12&endday=2016-12-18&tree=all

Comment 3

[Intermittent Failures Robot]

14 failures in 609 pushes (0.023 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 5
* autoland: 4
* try: 3
* mozilla-central: 1
* graphics: 1

Platform breakdown:
* linux64: 13
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1280099&startday=2016-12-19&endday=2016-12-25&tree=all

Comment 4

[Bulk Bug Changes for mreavy's org]

Mass change P3->P4 to align with new Mozilla triage process.

Comment 5

[Intermittent Failures Robot]

2 failures in 675 pushes (0.003 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* try: 2

Platform breakdown:
* linux64: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1280099&startday=2018-02-19&endday=2018-02-25&tree=all

Comment 6

[Cosmin Sabou [:CosminS]]

https://treeherder.mozilla.org/logviewer.html#?job_id=164351262&repo=mozilla-inbound&lineNumber=28814

Comment 7

[Intermittent Failures Robot]

4 failures in 831 pushes (0.005 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 4

Platform breakdown:
* linux32-stylo-disabled: 2
* linux64-qr: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1280099&startday=2018-02-26&endday=2018-03-04&tree=all

Comment 8

[Andreas Pehrson [:pehrsons]]

I've triggered this aplenty with my patches for bug 1436074.

Looks like bug 1280445 changed MediaEngineDefaultVideoSource to set mImage to nullptr on Stop(), and with the recent change in bug 1299515 to Stop() devices on track disabling we started appending nullptr images with size 0x0. The 0x0 caused us to not render the image at all when it should in fact have been black at the old resolution.

Comment 9

[Andreas Pehrson [:pehrsons]]

Note that this is not the same symptom as this bug was originally filed for, but likely the issue since the reopening in comment 6.

Comment 10

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1280099 - Retain image size after stopping MediaEngineDefaultVideoSource.

Review commit: https://reviewboard.mozilla.org/r/225434/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225434/

Comment 11

[Andreas Pehrson [:pehrsons]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=54c0945f17519d1bc02815e3c8a8c2251781d5be

Comment 12

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8956525 [details]
Bug 1280099 - Retain image size after stopping MediaEngineDefaultVideoSource.

https://reviewboard.mozilla.org/r/225434/#review231362

Lgtm.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/42c6ec43f782
Retain image size after stopping MediaEngineDefaultVideoSource. r=jib

Comment 14

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/42c6ec43f782