Set Window Size should not error on window size larger than screen

RESOLVED FIXED in Firefox 48

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ato, Assigned: ato)

Tracking

(Blocks 1 bug)

Version 3
mozilla50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed, firefox50 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

3 years ago
According to the WebDriver specification, when a requested window size is larger than the screen we should set the window containing the top-level browsing context to a size that is “as close as possible” to the requested size.

This is more in line with the current Selenium behaviour.

http://w3c.github.io/webdriver/webdriver-spec.html#dfn-set-window-size

See also https://github.com/mozilla/geckodriver/issues/56#issuecomment-225713923 for more information.
(Assignee)

Updated

3 years ago
Blocks: webdriver
(Assignee)

Comment 1

3 years ago
The specification says nothing about coercing to integer.

Review commit: https://reviewboard.mozilla.org/r/59234/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59234/
Attachment #8762735 - Flags: review?(dburns)
Attachment #8762736 - Flags: review?(dburns)
Attachment #8762737 - Flags: review?(dburns)
(Assignee)

Updated

3 years ago
Assignee: nobody → ato
Status: NEW → ASSIGNED
Attachment #8762735 - Flags: review?(dburns) → review+
Comment on attachment 8762736 [details]
Bug 1280101 - Remove check for window sizes larger than screen;

https://reviewboard.mozilla.org/r/59236/#review56804
Attachment #8762736 - Flags: review?(dburns) → review+
Comment on attachment 8762737 [details]
Bug 1280101 - Point out that test will only pass under X in a WM;

https://reviewboard.mozilla.org/r/59238/#review56806

Manipulating windows implies that we will need a window manager of sorts so don't think this comment is necessary
Attachment #8762737 - Flags: review?(dburns) → review-
(Assignee)

Comment 7

3 years ago
(In reply to David Burns :automatedtester from comment #6)
> Comment on attachment 8762737 [details]
> Bug 1280101 - Point out that test will only pass under X in a WM;
> 
> https://reviewboard.mozilla.org/r/59238/#review56806
> 
> Manipulating windows implies that we will need a window manager of sorts so
> don't think this comment is necessary

Well okay, but multiple people have been confused by this in the past.  Including me.
(Assignee)

Comment 8

3 years ago
Comment on attachment 8762735 [details]
Bug 1280101 - Do not coerce window dimensions to integer;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59234/diff/1-2/
(Assignee)

Comment 9

3 years ago
Comment on attachment 8762736 [details]
Bug 1280101 - Remove check for window sizes larger than screen;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59236/diff/1-2/
(Assignee)

Updated

3 years ago
Attachment #8762737 - Attachment is obsolete: true

Comment 10

3 years ago
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eca2ce2b6dd2
Do not coerce window dimensions to integer; r=automatedtester
https://hg.mozilla.org/integration/mozilla-inbound/rev/333518a265a2
Remove check for window sizes larger than screen; r=automatedtester

Comment 11

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/eca2ce2b6dd2
https://hg.mozilla.org/mozilla-central/rev/333518a265a2
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Backed out 85ccaed0061c from beta: https://hg.mozilla.org/releases/mozilla-beta/rev/2b22de79c849 to see if that fixes bug 1282937.
Flags: needinfo?(ato)
(Assignee)

Comment 14

3 years ago
I don’t know if I care enough to spend time figuring out why it breaks Windows on Beta.  I guess we can let the patch ride the train to Beta in a natural way.
Flags: needinfo?(ato)

Comment 15

3 years ago
Can you please confirm whether the fix for the window size error is done or rolled back. I am currently using FF 48+ and Selenium(2.53.1, 3.0.0-beta(123)) all give me the same exception unless i set the window size to 1024X768. This is breaking my tests because the elements are out of the window scope.

Comment 16

3 years ago
Can you please confirm whether the fix for the window size error is done or rolled back. I am currently using FF 48+ and Selenium(2.53.1, 3.0.0-beta(123)) all give me the same exception unless i set the window size to 1024X768. This is breaking my tests because the elements are out of the window scope.
(In reply to soumyamulu from comment #16)
> Can you please confirm whether the fix for the window size error is done or
> rolled back. I am currently using FF 48+ and Selenium(2.53.1,
> 3.0.0-beta(123)) all give me the same exception unless i set the window size
> to 1024X768. This is breaking my tests because the elements are out of the
> window scope.

This is done and will be available in Firefox 50.
You need to log in before you can comment on or make changes to this bug.