Closed Bug 1280129 Opened 3 years ago Closed 3 years ago

Update tasks to use v2 treeherder routes

Categories

(Taskcluster :: Services, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: garndt, Assigned: garndt)

Details

Attachments

(1 file)

A second version of routes for treeherder reporting is now supported by mozilla-taskcluster and taskcluster-treeherder.  This new route is in the form of:

tc-treeherder.v2.<project>.<revision>.<push log id>
Jobs reporting to treeherder should rely on the task route for project,
revision, and pushlog ID rather than things stuffed into task.extra.treeherder.

This also removes the need for a revision_hash that was calculated by mozilla-taskcluster.

Review commit: https://reviewboard.mozilla.org/r/59246/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59246/
Attachment #8762758 - Flags: review?(dustin)
here's a try push where it contains the newer routes:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b38bbd81a0af
Comment on attachment 8762758 [details]
Bug 1280129 - Update tasks to use v2 treeherder routes

https://reviewboard.mozilla.org/r/59246/#review56300

This looks good.  I won't be sad to see the backside of revision_hash.  Is there any need to use both routes simultaneously for a duration, or is the immediate switch OK?
Attachment #8762758 - Flags: review?(dustin) → review+
The immediate switch should be ok, mozilla-taskcluster (hopefully) will handle either one appropriately.
Comment on attachment 8762758 [details]
Bug 1280129 - Update tasks to use v2 treeherder routes

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59246/diff/1-2/
Changes made in comment 5 are just to rebase so there isn't a merge conflict any longer.
Pushed by garndt@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/099196831d4c
Update tasks to use v2 treeherder routes r=dustin
https://hg.mozilla.org/mozilla-central/rev/099196831d4c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Component: Integration → Services
You need to log in before you can comment on or make changes to this bug.