1280133 - Toolbar in Linux uses low rez assets on hidpi displays

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Eitan Isaacson [:eeejay]]

The pretty toolbar icons are fuzzy in Linux!

It looks like the osx assets are (mostly) identical to Linux. I'll just copy them over and update the CSS..

I think the only exception is the restore from fullscreen icon, but I don't know where that is used anymore.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1280133 - Add hidpi toolbar icons for Linux.

Review commit: https://reviewboard.mozilla.org/r/59254/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59254/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8762767 [details]
Bug 1280133 - Add hidpi toolbar icons for Linux.

https://reviewboard.mozilla.org/r/59254/#review56304

This should use the Windows icons like the non-hidpi version, not the OS X ones.

Comment 3

[Eitan Isaacson [:eeejay]]

(In reply to :Gijs Kruitbosch from comment #2)
> Comment on attachment 8762767 [details]
> Bug 1280133 - Add hidpi toolbar icons for Linux.
> 
> https://reviewboard.mozilla.org/r/59254/#review56304
> 
> This should use the Windows icons like the non-hidpi version, not the OS X
> ones.

The mac ones are almost identical to the Linux ones (with a very slightly diminished highlight). Windows and its sub-themes all have different colors and embossing.

I'll needinfo shorelnder, he may think they need to be made from scratch. It would be nice if the scalable versions of these were available somewhere (even in-tree!).

I'll also upload a side-by-side screenshot to prove my point.

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: toolbar-difference.png

Here is a before and after screenshot. Its like 20x better!!

Also, you can see the activity stream and test pilot icons stick out right now and look really bad next to the low dpi icons.

Comment 5

[:Gijs (he/him)]

(In reply to Eitan Isaacson [:eeejay] from comment #3)
> (In reply to :Gijs Kruitbosch from comment #2)
> > Comment on attachment 8762767 [details]
> > Bug 1280133 - Add hidpi toolbar icons for Linux.
> > 
> > https://reviewboard.mozilla.org/r/59254/#review56304
> > 
> > This should use the Windows icons like the non-hidpi version, not the OS X
> > ones.
> 
> The mac ones are almost identical to the Linux ones (with a very slightly
> diminished highlight). Windows and its sub-themes all have different colors
> and embossing.

Well, right, and the OS X one also has different colors, but also has different fullscreen button imagery, different window iconography on e.g. new window, etc.

bug 874674 made the linux ones the same as the windows ones. I've lost track of which image you want, but they ought to be the same.

> 
> I'll needinfo shorelnder, he may think they need to be made from scratch. It
> would be nice if the scalable versions of these were available somewhere
> (even in-tree!).
> 
> I'll also upload a side-by-side screenshot to prove my point.

But it would be trivial to just copy the right windows image. What's the problem with that?

Comment 6

[Eitan Isaacson [:eeejay]]

(In reply to :Gijs Kruitbosch from comment #5)
> (In reply to Eitan Isaacson [:eeejay] from comment #3)
> > (In reply to :Gijs Kruitbosch from comment #2)
> > > Comment on attachment 8762767 [details]
> > > Bug 1280133 - Add hidpi toolbar icons for Linux.
> > > 
> > > https://reviewboard.mozilla.org/r/59254/#review56304
> > > 
> > > This should use the Windows icons like the non-hidpi version, not the OS X
> > > ones.
> > 
> > The mac ones are almost identical to the Linux ones (with a very slightly
> > diminished highlight). Windows and its sub-themes all have different colors
> > and embossing.
> 
> Well, right, and the OS X one also has different colors, but also has
> different fullscreen button imagery, different window iconography on e.g.
> new window, etc.
> 
> bug 874674 made the linux ones the same as the windows ones. I've lost track
> of which image you want, but they ought to be the same.
> 
> > 
> > I'll needinfo shorelnder, he may think they need to be made from scratch. It
> > would be nice if the scalable versions of these were available somewhere
> > (even in-tree!).
> > 
> > I'll also upload a side-by-side screenshot to prove my point.
> 
> But it would be trivial to just copy the right windows image. What's the
> problem with that?

In bug 969904 shorlander updated the Linux toolbar and it no longer matches the XP theme.

Here it is before:
http://hg.mozilla.org/mozilla-central/raw-file/80fda301471/browser/themes/linux/Toolbar.png

And it was identical to the XP theme:
http://hg.mozilla.org/mozilla-central/raw-file/80fda301471/browser/themes/windows/Toolbar-XP.png

Here it is after:
http://hg.mozilla.org/mozilla-central/raw-file/02be46ac2b5/browser/themes/linux/Toolbar.png

The closest one is the osx one:
http://hg.mozilla.org/mozilla-central/raw-file/02be46ac2b5/browser/themes/osx/Toolbar.png

It doesn't match windows anymore. XP, or any of the other sub-theme.

Comment 7

[Stephen Horlander [:shorlander]]

Attachment: [e-mail]

Comment 8

[Stephen Horlander [:shorlander]]

Attachment: [e-mail]

Comment 9

[Eitan Isaacson [:eeejay]]

Comment on attachment 8762767 [details]
Bug 1280133 - Add hidpi toolbar icons for Linux.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59254/diff/1-2/

Comment 10

[:Gijs (he/him)]

Comment on attachment 8762767 [details]
Bug 1280133 - Add hidpi toolbar icons for Linux.

https://reviewboard.mozilla.org/r/59254/#review59346

Thanks!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e0a4baa176e
Add hidpi toolbar icons for Linux. r=Gijs

Comment 12

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/4e0a4baa176e