1280164 - Wrong assertions in WorkerRunnable::Pre/PostDispatch

Status: RESOLVED INVALID

(Core :: DOM: Workers, defect, P3)

Description

[Andrea Marchesini [:baku]]

When a WorkerRunnable is created with WorkerThreadModifyBusyCount we want it to be created outside the target worker. This means parent process or main-thread. This is what we do everywhere in gecko (and in particular parent-Worker to target-worker is just happening internally in WorkerPrivate code).

In our code base, the use of WorkerRunnable+WorkerThreadModifyBusyCount as base class is not so common. Usually we use some other base class such as WorkerMainThreadRunnable. And all of these classes have custom PreDispatch/PostDispatch.

The only places where we use WorkerRunnable+WorkerThreadModifyBusyCount is in ServiceWorker code and here, the current assertions work fine because such runnables are always created on the main-thread and target SWs are always top-level workers (they cannot be sub-workers).

The intent of this patch is to update the assertion in order to cover the reality of the use of WorkerRunnable in our code base.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: runnable3.patch

Comment 2

[Andrea Marchesini [:baku]]

Attachment: part 1

Comment 3

[Andrea Marchesini [:baku]]

Attachment: part 2

Comment 4

[Marion Daly [:mdaly]]

Baku: okay if I unassign you from this bug?

Comment 5

[Andrea Marchesini [:baku]]

This bug is not valid anymore.