Closed Bug 1280167 Opened 3 years ago Closed 3 years ago

WebSocket WorkerRunnableDispatcher uses ModifyBusyCountFromWorker wrongly

Categories

(Core :: DOM: Workers, defect)

49 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

(Whiteboard: btpp-active)

Attachments

(1 file, 2 obsolete files)

No description provided.
Attachment #8762795 - Flags: review?(jonas)
Attachment #8762795 - Attachment description: runnable5.patch → part 1 - WorkerRunnableDispatcher
Depends on: 1279977
Depends on: 1280067
Whiteboard: btpp-active
Attached patch 1280167_runnable_webSocket.patch (obsolete) — Splinter Review
Attachment #8762795 - Attachment is obsolete: true
Attachment #8762795 - Flags: review?(jonas)
Attachment #8770682 - Flags: review?(khuey)
Comment on attachment 8770682 [details] [diff] [review]
1280167_runnable_webSocket.patch

Review of attachment 8770682 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/WebSocket.cpp
@@ +2797,5 @@
>      // wrong thing about which thread we're on.  We're on whichever thread the
>      // channel implementation is running on (probably the main thread or socket
>      // transport thread).
> +    aWorkerPrivate->
> +      ModifyBusyCountFromWorker(WorkerPrivate::eIncreaseBusyCount);

Why do we need this at all?
Right, we don't need anything here.
Attachment #8770682 - Attachment is obsolete: true
Attachment #8770682 - Flags: review?(khuey)
Flags: needinfo?(amarchesini)
Attachment #8773184 - Flags: review?(khuey)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/79b1ba1f1f4b
WebSocket WorkerRunnableDispatcher uses ModifyBusyCountFromWorker wrongly, r=khuey
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5832850a42d9
"WebSocket WorkerRunnableDispatcher uses ModifyBusyCountFromWorker wrongly" [r=khuey]
https://hg.mozilla.org/mozilla-central/rev/5832850a42d9
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.