Closed
Bug 1280167
Opened 3 years ago
Closed 3 years ago
WebSocket WorkerRunnableDispatcher uses ModifyBusyCountFromWorker wrongly
Categories
(Core :: DOM: Workers, defect)
Not set
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
References
Details
(Whiteboard: btpp-active)
Attachments
(1 file, 2 obsolete files)
|
1.89 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•3 years ago
|
||
Attachment #8762795 -
Flags: review?(jonas)
|
|
Assignee | |
Updated•3 years ago
|
Attachment #8762795 -
Attachment description: runnable5.patch → part 1 - WorkerRunnableDispatcher
|
||
Updated•3 years ago
|
Whiteboard: btpp-active
|
|
Assignee | |
Comment 2•3 years ago
|
||
Attachment #8762795 -
Attachment is obsolete: true
Attachment #8762795 -
Flags: review?(jonas)
Attachment #8770682 -
Flags: review?(khuey)
Comment on attachment 8770682 [details] [diff] [review] 1280167_runnable_webSocket.patch Review of attachment 8770682 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/base/WebSocket.cpp @@ +2797,5 @@ > // wrong thing about which thread we're on. We're on whichever thread the > // channel implementation is running on (probably the main thread or socket > // transport thread). > + aWorkerPrivate-> > + ModifyBusyCountFromWorker(WorkerPrivate::eIncreaseBusyCount); Why do we need this at all?
Flags: needinfo?(amarchesini)
|
|
Assignee | |
Comment 4•3 years ago
|
||
Right, we don't need anything here.
Attachment #8770682 -
Attachment is obsolete: true
Attachment #8770682 -
Flags: review?(khuey)
Flags: needinfo?(amarchesini)
Attachment #8773184 -
Flags: review?(khuey)
Attachment #8773184 -
Flags: review?(khuey) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/79b1ba1f1f4b WebSocket WorkerRunnableDispatcher uses ModifyBusyCountFromWorker wrongly, r=khuey
Backout by ihsiao@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0a0f2f8db1e6 Backed out changeset 79b1ba1f1f4b
Pushed by ihsiao@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5832850a42d9 "WebSocket WorkerRunnableDispatcher uses ModifyBusyCountFromWorker wrongly" [r=khuey]
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5832850a42d9
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•