1280175 - Allow passing lvalue to MediaEventProducerExc<T>::Notify

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

Consider the following code:

int i = 3;
MediaEventProducerExc<int> source;
source.Notify(i);

A compile error will be emitted:
error: cannot bind ‘int’ lvalue to ‘int&&’

We should allow both rvalue and lvalue so the client can invoke copy or move constructor as it sees fit.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Btw, it is also awkward to say:
|source.Notify(Move(i))| in order to compile as far as |i| is just an int.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1280175 - Allow passing lvalue to MediaEventProducerExc<T>::Notify.

Review commit: https://reviewboard.mozilla.org/r/59280/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59280/

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8762807 [details]
Bug 1280175 - Allow passing lvalue to MediaEventProducerExc<T>::Notify.

https://reviewboard.mozilla.org/r/59280/#review56292

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/66799d393492
Allow passing lvalue to MediaEventProducerExc<T>::Notify. r=gerald

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/66799d393492